slight improvement on the Local Modules subsection #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a proposal for a slight improvement on the Local Modules subsection
|
Thanks for contributing @sukruozan! Your changes look good but I'm not sure they add anything in terms of improving the understanding for a user that is just getting started, where we want the examples to be quite minimal. Happy to be convinced otherwise but if you are looking to contribute more generally don't hesitate to reach out. |
fpliger
added
tag: docs
|
Agree with @philippjfr sentiment here. Really really appreciate your contribution but keeping in mind the huge focus of the project on making programming accessible, the changes arguably make it harder for "not so technical" users to read the example. Definitely open to being convinced otherwise, as mentioned above :) |
|
Closing this per comments. @sukruozan please feel free to re-open per Philipps comments . TY! |
fpliger
added
status: declined
|
Dear Philipp,
Thanks for your quick response. I totally understand your hesitation. Mine
was just an unnecessary suggestion for your consideration. And thank you
for your contributions to the Python community!
On 1 May 2022 Sun at 18:02 Philipp Rudiger ***@***.***> wrote:
Thanks for contributing @sukruozan <https://github.com/sukruozan>! Your
changes look good but I'm not sure they add anything in terms of improving
the understanding for a user that is just getting started, where we want
the examples to be quite minimal. Happy to be convinced otherwise but if
you are looking to contribute more generally don't hesitate to reach out.
—
Reply to this email directly, view it on GitHub
<#92 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5KMX4XE7FV6SPQ2DSXLL3VH2MIVANCNFSM5UZ7KEVA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Şükrü Ozan, Ph.D.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a proposal for a slight improvement on the Local Modules subsection