New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test and add new ones to close 878 #971
Fix test and add new ones to close 878 #971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to lint it 😅 |
Is this waiting on the CI to pass? If yes, I think #978 fixes it. |
Thanks @madhur-tandon will try now! ;) |
Ah no, I guess it's something else. |
Okay. I have no idea why this is failing. |
I'm not sure why but I had to rebase main into my other branch for the tests to pick up the changes |
Interesting, alright =) |
Ah, well cause it's running from the previous yamls |
1752d7f
to
45f7e78
Compare
Fixed the tests that were xfail or failing + added a new test to make @antocuni happy.
Intends to close #878