Sorts: Stronger type checks for composite sorts #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructors for ArrayType and FunctionType take other sorts. Due to the similar spelling of constant constructor and types, it is easy to type: ArrayType(Real, Real) instead of ArrayType(REAL, REAL) This change adds a check in those constructors to enforce the arguments to be of type PySMTType.
nbailluet
pushed a commit
to nbailluet/pysmt
that referenced
this pull request
Mar 14, 2024
Sorts: Stronger type checks for composite sorts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructors for ArrayType and FunctionType take other sorts. Due to the
similar spelling of constant constructor and types, it is easy to type:
ArrayType(Real, Real)
instead of
ArrayType(REAL, REAL)
This change adds a check in those constructors to enforce the arguments
to be of type PySMTType.