Minor Fixes #1389
Closed
Minor Fixes #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 29, 2016 15:51
added 22 commits
October 29, 2016 16:17
|
This looks great! A number of the changes are to files from our upstream project, though; could we undo the changes to If you're ok with it I'm also happy to do this myself and commit it. |
|
Yeah sure! It'd be cool if you could do the changes … I don't have the time right now. Thanks! |
kmod
added a commit
to kmod/pyston_
that referenced
this pull request
Nov 6, 2016
Minus the ones to code that we inherited from CPython or LLVM, in order to keep those diffs clean.
|
Awesome, merged it in #1394! I would humbly suggest thinking of some way to make these PRs easier to accept, though. I was happy to take the time to pick through the changes, but I could see other people feeling differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this merge request fixes some minor issues.
It was created with help of Feram.
If it helped to improve this repository,
please consider to star Feram's repo to show some love! 😊
PS:
The Feram team is currently working on making this technology
available for everyone. If you want to be one of the first to use it,
please sign up up for the newsletter on feram.co.