Hotstart save (aka "Bread Crumbs") #179
Conversation
|
@bemcdonnell, this is the functionality that we discussed a few weeks ago. |
|
@jsadler2, If you check the appveyor and travis logs, it will tell you what's going on with your compilation. Just for point of reference, what compiler are you building with on you local machine? And did you run the regression tests? |
|
@jsadler2, my first suggesting is to rebase your changes off the most recent |
|
Thanks, @bemcdonnell. I'll rebase and go from there. I am using the linux |
|
@jsadler2, i'm going to check to see if I can push past the build issue. I overcame some very strange behavior like this with the VC2010 compiler on my own machine. |
|
@bemcdonnell okay. Thanks. I'll keep working on it too. |
…water-Management-Model into hotstart_save
|
@jsadler2, could you please sign the contributors license agreement (see CLAHUB, above). Also, we still need to diagnose what is going on with the visual studio build. |
There was a problem hiding this comment.
@jsadler2, Nice work on this PR. I have a couple of questions/thoughts.
As I commented before, we have to figure out what is going on with Visual Studio build. Also, we have a fully running set of unit tests now. Please add the unit tests for this new functionality. You can generate your own test_breadCrumbs.cpp if you want to. There are two genres of unit tests - 1. error checking asserting that you get the correct errors and 2. mechanical tests that show whether it is working.
I'm wondering if the original built-in functionality of the HSF still works as you are saving new HSFs. Can you confirm this with a unit test? I may circle back with some other comments as soon as I get a few minutes to fetch these changes and build it locally.
| @brief Save hotstart file during simulation | ||
| @param hsfile The file name of the hotstart file that user would like to save | ||
| */ | ||
| void DLLEXPORT save_hotstart(char *hsfile); |
There was a problem hiding this comment.
Sticking with the convention, please pre-pend the exportable functions with swmm_*
| @@ -1524,6 +1526,40 @@ int DLLEXPORT swmm_setGagePrecip(int index, double total_precip) | |||
| return(errcode); | |||
| } | |||
|
|
|||
| void DLLEXPORT save_hotstart(char *hsfile) | |||
There was a problem hiding this comment.
@jsadler2, 4 spaces instead of tabs.
|
@bemcdonnell roger that about the unit tests. |
|
@jsadler2, could you provide an update on the status of this PR? If you decide not to continue to develop it, we can merge it into a feature branch and then we can merge it in down the road once it the tests are built out. Just let me know what is best for you! |
|
Hey @bemcdonnell, thanks for checking in on this. I've had to put this on the back-burner. I would like to continue developing it though. Is it okay for you guys to have the unit tests and the changes you requested in three weeks (by 11/13)? |
|
@bemcdonnell a few weeks later and I still haven't had a chance to look at this PR more. At this point, unfortunately, I don't think I can really put much time into this. |
|
This is an interesting idea, is the general concept to have a date in the hot start file so that a new run can be started at any time? |
|
@jsadler2, do you mind if I takeover this pull request? |
Here are modifications to enable saving hotstart files during a simulation. This allows users to leave "bread crumbs" during a simulation so they can restart a simulation from a custom point.