Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting when converting set to tuple #155

Closed
wants to merge 1 commit into from

Conversation

Hellsegga
Copy link
Contributor

Fixes #154

I'm not very familiar with the code base yet and not sure this is a good way to solve it.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #155 (8737269) into main (e1d1e9e) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   75.02%   75.11%   +0.08%     
==========================================
  Files          22       22              
  Lines        2515     2512       -3     
==========================================
  Hits         1887     1887              
+ Misses        628      625       -3     
Impacted Files Coverage Δ
toponetx/classes/simplicial_complex.py 86.59% <100.00%> (+0.53%) ⬆️

@mhajij mhajij self-requested a review June 13, 2023 03:26
Copy link
Member

@mhajij mhajij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure the lint test pass?

Make sure you do

pre-commit install

then the lint changes will be done to you automatically.

Copy link
Member

@ffl096 ffl096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test case (your example from #154 should be fine) to avoid any future regression?

@mhajij mhajij closed this Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mix of ordered and unordered data structures
3 participants