typecheck: Adding check for type resolving to generic containing same type #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-yz-liu
reviewed
Aug 7, 2018
python_ta/typecheck/base.py
Outdated
| @@ -505,7 +505,10 @@ def resolve(self, t: type) -> TypeResult: | |||
| try: | |||
| repr = self.find_repr(self.type_to_tnode[str(t)]) | |||
| if repr and repr.type is not t: | |||
| return self.resolve(repr.type) | |||
| if getattr(repr.type, '__args__', None) is not None and any(elt is t for elt in repr.type.__args__): | |||
There was a problem hiding this comment.
This can be simplified by using getattr directly in the comprehension in the any: any(elt is t for elt in getattr(...)), of course choosing a good default value.
justinpark715
force-pushed
the
resolve-generic-typevar
branch
from
dca6dd9
to
80b64c2
Compare
justinpark715
force-pushed
the
resolve-generic-typevar
branch
from
80b64c2
to
6610f44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by recursion errors raised by student code when creating nested lists with append