Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Add missing toml dependency #836

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

david-yz-liu
Copy link
Contributor

@david-yz-liu david-yz-liu commented Aug 8, 2022

Motivation and Context

#807 added a dependency on toml, but this was missing from the setup.cfg package config. I suspect the reason we didn't catch this in testing was one of the dev dependencies has a transitive dependency on toml.

Your Changes

Description: Added toml dependency.

Type of change (select all that apply):

  • Bug fix (non-breaking change which fixes an issue)
  • Other (please specify): dependency update

Testing

Manual testing.

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.
  • I have updated the CHANGELOG.md file.

@david-yz-liu david-yz-liu merged commit f433db7 into pyta-uoft:master Aug 8, 2022
@david-yz-liu david-yz-liu deleted the toml-dependency branch August 8, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant