Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch config #807

Merged
merged 11 commits into from
Apr 18, 2022
Merged

Patch config #807

merged 11 commits into from
Apr 18, 2022

Conversation

peelstnac
Copy link
Contributor

@peelstnac peelstnac commented Mar 31, 2022

Motivation and Context

Monkey patched error messages were stored in global dictionary variable. It would be better to move them into a .toml file and allow for the user to specify their own .toml file if they wish.

Your Changes

Move custom error messages into messages_config.toml. Allow for user to specify path to their own custom .toml file in .pylintrc.

Description:

Type of change (select all that apply):

  • Refactoring (internal change to codebase, without changing functionality)

Testing

All tests pass.

Questions and Comments (if applicable)

Checklist

  • I have performed a self-review of my own code.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported on Coveralls.

@peelstnac peelstnac marked this pull request as ready for review April 14, 2022 22:13
Copy link
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peelstnac thank you, and great work!

@david-yz-liu david-yz-liu merged commit 02e84b7 into pyta-uoft:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants