Fix check_contracts handling of forward references in type annotations #941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
A recent change caused
@check_contracts
to evaluate instance attribute type annotations when the class definition was first reached, which raised an error when the type annotations had forward references. One example is for linked list nodes:Your Changes
Description: Delay evaluate of the class type annotations until the first time an attribute is set (or a method is called).
Type of change (select all that apply):
Testing
Added test cases and manual testing.
Questions and Comments (if applicable)
Checklist