-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated pytest_namespace #9
Conversation
@nicoddemus I'm new to this. Does this need another approval or do I have to close the MR? |
@schollii is the main maintainer, we should ask for his input first. 😁 |
Thanks let me have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests pass and @PhilippSelenium your own use of plugin with pytest works with your fix so in theory, it should be good to merge.
However one concern is that the tests did not fail prior... @PhilippSelenium do you mind checking if the problem was caught prior, maybe this got missed because they are not run regularly, not sure. If no test failure with old code, could you add a test that exercises the hook, so if it changes again the future, we'll know.
@schollii The tests do fail on master branch with the latest pytest version:
The problem is that the tests have not been run since 2016. Is there a possibility to enable nightly or at least weekly builds? |
ping |
@nicodemus I've been out of the loop on such details what do you recommend to resolve this, does setting this up require anything from me? |
Hi @schollii, Can you access https://travis-ci.org/github/pytest-dev/nose2pytest/settings? |
(Regardless, I think this is good to merge and release 👍) |
Fix #8