Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated pytest_namespace #9

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

PhilippSelenium
Copy link
Contributor

@PhilippSelenium PhilippSelenium commented Apr 1, 2020

Fix #8

@PhilippSelenium
Copy link
Contributor Author

@nicoddemus I'm new to this. Does this need another approval or do I have to close the MR?

@nicoddemus
Copy link
Member

@schollii is the main maintainer, we should ask for his input first. 😁

@schollii
Copy link
Collaborator

schollii commented Apr 4, 2020

Thanks let me have a look

Copy link
Collaborator

@schollii schollii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests pass and @PhilippSelenium your own use of plugin with pytest works with your fix so in theory, it should be good to merge.

However one concern is that the tests did not fail prior... @PhilippSelenium do you mind checking if the problem was caught prior, maybe this got missed because they are not run regularly, not sure. If no test failure with old code, could you add a test that exercises the hook, so if it changes again the future, we'll know.

@PhilippSelenium
Copy link
Contributor Author

PhilippSelenium commented Apr 6, 2020

@schollii The tests do fail on master branch with the latest pytest version:

pluggy.manager.PluginValidationError: unknown hook 'pytest_namespace' in plugin

The problem is that the tests have not been run since 2016. Is there a possibility to enable nightly or at least weekly builds?
Or do you as a maintainer have the possibility to trigger a testrun on master?

@PhilippSelenium
Copy link
Contributor Author

ping

@schollii
Copy link
Collaborator

schollii commented Jun 4, 2020

@nicodemus I've been out of the loop on such details what do you recommend to resolve this, does setting this up require anything from me?

@nicoddemus
Copy link
Member

@nicoddemus
Copy link
Member

(Regardless, I think this is good to merge and release 👍)

@nicoddemus nicoddemus merged commit aeaaecb into pytest-dev:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PluginValidationError when plugin is installed
3 participants