Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression for firstresult hook without implementation #68

Closed
RonnyPfannschmidt opened this issue Aug 29, 2017 · 2 comments
Closed

regression for firstresult hook without implementation #68

RonnyPfannschmidt opened this issue Aug 29, 2017 · 2 comments
Assignees
@goodboy
Labels
bug

Comments

@RonnyPfannschmidt
Copy link
Member

devpi/devpi#458

is triggered by https://github.com/pytest-dev/pluggy/pull/58/files#diff-85f4be4e30ec3b4f3d53843b24d72141R109

@tgoodlet i beleive a test is needed for those edge behaviours
@goodboy goodboy self-assigned this Aug 29, 2017
@goodboy goodboy added the bug label Aug 29, 2017
@goodboy
Copy link
Contributor

goodboy commented Aug 29, 2017

@RonnyPfannschmidt shoot!
Yeah I guess we need more complete testing..
I actually was able to trigger this once but could never reproduce.
I'll get a PR in stat!

goodboy pushed a commit to goodboy/pluggy that referenced this issue Aug 29, 2017
Handle firstresult hooks that return None
e627c3d 
Only return the first result when at least one result has been returned
by underlying hook implementations.

Fixes pytest-dev#68
goodboy pushed a commit to goodboy/pluggy that referenced this issue Aug 29, 2017
Handle firstresult hooks that return None
6954151 
Only return the first result when at least one result has been returned
by underlying hook implementations.

Fixes pytest-dev#68
@goodboy goodboy mentioned this issue Aug 29, 2017
Merged
@goodboy
Copy link
Contributor

goodboy commented Aug 29, 2017

@RonnyPfannschmidt got a fix up.

Isn't it a bit odd that the devpi main routine is invoking

res = xom.config.hook.devpiserver_cmdline_run(xom=xom)

which according to the spec is supposed to return an exit code?

Maybe I'm missing something but that seems like odd behaviour that all impls are called without any handling the cmdline (or maybe not returning a result when they're supposed to)?

goodboy pushed a commit to goodboy/pluggy that referenced this issue Aug 29, 2017
Handle firstresult hooks that return None
e8fe1be 
Only return the first result when at least one result has been returned
by underlying hook implementations.

Fixes pytest-dev#68
goodboy pushed a commit to goodboy/pluggy that referenced this issue Aug 29, 2017
0.5.1 patch release
40ffe72 
Fixes pytest-dev#68 and get's pytest-dev#69 into the wild stat!
@goodboy goodboy mentioned this issue Aug 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goodboy goodboy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RonnyPfannschmidt @goodboy