Handle first result with None results #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
at first glance i wonder if that test should trigger the behaviour, i was under the impression lack of plug-ins should trigger it |
|
That test definitely gets the exact same error so the fix should handle both cases. |
|
indeed https://github.com/pytest-dev/pluggy/blob/master/pluggy/callers.py#L92 so firstresult shortcuts, and there should always be zero or one results |
RonnyPfannschmidt
approved these changes
Aug 29, 2017
|
@RonnyPfannschmidt added that second test as well. |
|
haha wow totally broke it.. |
When calling a firstresult hook, if no implementation returns a non-None value a bug is exposed in the new `_MultiCall` which assumes there will be a least one result.
goodboy
force-pushed
the
firstresult_is_none
branch
from
8fd6900
to
e8fe1be
Compare
Only return the first result when at least one result has been returned by underlying hook implementations. Fixes pytest-dev#68
goodboy
force-pushed
the
firstresult_is_none
branch
from
e8fe1be
to
f1a2270
Compare
|
there finally.. @nicoddemus just waiting on your stamp of approval 😄 |
asottile
approved these changes
Aug 29, 2017
goodboy
pushed a commit
to goodboy/pluggy
that referenced
this pull request
Aug 29, 2017
Fixes pytest-dev#68 and get's pytest-dev#69 into the wild stat!
Merged
nicoddemus
reviewed
Aug 29, 2017
This was referenced Sep 6, 2017
This was referenced Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #68...
If you guys are happy with this I'll push up a patch release
0.5.1...