Have at least one separator in sep()

[asottile]

Before:

 1 failed, 1 passed, 1 skipped, 1 deselected, 1 xfailed, 1 xpassed, 1 error in 0.04 seconds

After:

= 1 failed, 1 passed, 1 skipped, 1 deselected, 1 xfailed, 1 xpassed, 1 error in 0.04 seconds =

---

This is slightly selfish -- I'm doing this to make the output in this case possible to colorize for pygments-pytest

[RonnyPfannschmidt]

i cant wait to kill the pylib dependency of terminal-writer ^^

[RonnyPfannschmidt]

question - how does this affect normal terminal output?

if this triggers line-wraps of separator lines for single separators, then its absolutely unacceptable

[RonnyPfannschmidt]

as for a solution - if that is the case - we could opt in or out based on whether its a tty - but it would trigger inconsistent line lengths

[asottile]

This change can cause more wrapping, but I think the consistency in output is worth it.

Here's a small demo:

from py.io import TerminalWriter

tw = TerminalWriter()

for i in range(70, 82):
    msg = f'{i} chars: '
    msg += 'X' * (i - len(msg))
    tw.sep('=', msg)
    print()

before

Some notably bad actors:

• 77 characters ends up with a single separator on the right (???)
• 79 characters wraps, the wrapping character is a space 😆

after

[asottile]

basically, the only time this is going to make a difference is when the centered string is N - 3 and N - 2 characters in length -- otherwise it was already going to wrap

[RonnyPfannschmidt]

@asottile this is about as bad as rubbing my ocd with napalm

[RonnyPfannschmidt]

but it also solves a pytest issue that's hidden somewhere about no longer being able to distinguish certain things

[asottile]

oh right, I don't have merge or release privs here 🙃