-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: use Ubuntu Xenial, pypy3, coverage #208
Conversation
Hopefully helps with py2 failure: https://travis-ci.org/pytest-dev/py/jobs/492914885
@nicoddemus |
Coverage can be seen at https://codecov.io/gh/pytest-dev/py/tree/a54d2d325b0f63fa244a0096af574a0f0c255295. |
TBH I'm not entirely happy with codecov in general, we have been having frequent problems with it: connection resets during builds causing them to fail (albeit in the last week or so I have not seen those anymore), and coverage changes that we could not explain (doc only changes making coverage drop for example). What is your opinion? |
Yes, codecov can be annoying (mostly the connection timeouts, but this might be caused by using (many) flags after all). I've started investigating other providers, but in general (if it is working) codecov is still one of the best. |
We can leave coverage out of this PR for now, but I've figured that it would be helpful with checking if we miss something (I've started to add support / fixes for newer pytest). |
Primarily I wanted to get CI going again here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, that's a worthy endeavor! 🤗
Please see my comments. 👍
#- DEPS="pytest~=3.1.0" | ||
- DEPS="pytest~=2.9.0" | ||
- DEPS="pytest~=3.0.0" | ||
#- DEPS="pytest~=3.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before already, just indented.
Would be changed in the next step, e.g. by testing against pytest 4.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops did not notice that, sorry
- '3.4' | ||
- '3.5' | ||
- '3.6' | ||
# - 'pypy2.7-6.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since pypy is failing anyway, I've only kept pypy3 (previously it was only pypy).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough
No description provided.