Drop dependency on py.io #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytest 7.2.0 dropped its dependency on the `py` package. We don't specify `py` explicitly as a dependency, so tests starting failing since the release of pytest 7.2.0. To drop this dependency, pytest vendored `py.io.TerminalWriter` into `_pytest._io` in pytest commit 276405a03 (6.0.0rc1). It looks like we still support pytest 5.0 —at least it's listed in tox.ini— so I fall back to importing from `py.io` if it isn't present in `_pytest`. This was our only direct use of the `py` library.
We require pytest>=6.2; `_pytest._io.TerminalWriter` exists since 6.0.0rc1. See the previous commit for details.
These aren't used in the `envlist` earlier in `tox.ini`. `CHANGES.rst` says we require pytest>=6.2.
This was referenced Nov 3, 2022
Codecov ReportBase: 98.49% // Head: 98.49% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 32 32
Lines 733 733
Branches 16 16
=======================================
Hits 722 722
Misses 9 9
Partials 2 2 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since pytest 7.2.0 was released 2 weeks ago (2022-10-23), CI fails against
pytest-latest:Pytest 7.2.0 dropped its dependency on the
pypackage. We don't specifypyexplicitly as a dependency, so tests starting failing since the release of pytest 7.2.0.To drop this dependency, pytest vendored
py.io.TerminalWriterinto_pytest._ioin pytest commit 276405a03 (6.0.0rc1). We require pytest>=6.2, so we can import it from there.