Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dependency on py.io #571

Merged
merged 3 commits into from Nov 3, 2022
Merged

Drop dependency on py.io #571

merged 3 commits into from Nov 3, 2022

Commits on Nov 3, 2022

  1. Drop dependency on py.io 

    Pytest 7.2.0 dropped its dependency on the `py` package. We don't
specify `py` explicitly as a dependency, so tests starting failing since
the release of pytest 7.2.0.

To drop this dependency, pytest vendored `py.io.TerminalWriter` into
`_pytest._io` in pytest commit 276405a03 (6.0.0rc1). It looks like we
still support pytest 5.0 —at least it's listed in tox.ini— so I fall
back to importing from `py.io` if it isn't present in `_pytest`.

This was our only direct use of the `py` library.
    @drothlis
    drothlis committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    36e81cb View commit details
    Browse the repository at this point in the history

  2. Don't fall back to importing from py.io 

    We require pytest>=6.2; `_pytest._io.TerminalWriter` exists since
6.0.0rc1. See the previous commit for details.
    @drothlis
    drothlis committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    72d49f3 View commit details
    Browse the repository at this point in the history

  3. tox.ini: Remove unsupported pytest versions < 6.2 

    These aren't used in the `envlist` earlier in `tox.ini`.
`CHANGES.rst` says we require pytest>=6.2.
    @drothlis
    drothlis committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    411afa6 View commit details
    Browse the repository at this point in the history