-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make project Blacked #11
Conversation
.gitignore
Outdated
build | ||
dist | ||
!.travis.yml | ||
!.pre-commit-config.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for this change? I'd be concerned that any important new files would be ignored as a result of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No specific reason, just a simplification that I've been using in my own projects. I can revert to the explicit style. 👍
|
||
$ pipenv install --dev | ||
$ pre-commit install | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this. Could you also add a note about running the tests?
README.rst
Outdated
Development | ||
----------- | ||
|
||
To contribute to pytest-metadata: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth mentioning and linking to appropriate sources for installing pipenv and pre-commit.
tox.ini
Outdated
|
||
[flake8] | ||
# Ignore line length, `black` handles that | ||
extend-ignore = E501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to change the max line length, as IDEs may be using this value to discourage long line lengths in the first place.
Could you also add a badge to the README to indicate the project uses black? |
No description provided.