Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make project Blacked #11

Merged
merged 2 commits into from
Nov 13, 2018
Merged

Make project Blacked #11

merged 2 commits into from
Nov 13, 2018

Conversation

BeyondEvil
Copy link
Contributor

No description provided.

.gitignore Outdated
build
dist
!.travis.yml
!.pre-commit-config.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this change? I'd be concerned that any important new files would be ignored as a result of this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific reason, just a simplification that I've been using in my own projects. I can revert to the explicit style. 👍


$ pipenv install --dev
$ pre-commit install

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Could you also add a note about running the tests?

README.rst Outdated
Development
-----------

To contribute to pytest-metadata:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth mentioning and linking to appropriate sources for installing pipenv and pre-commit.

tox.ini Outdated

[flake8]
# Ignore line length, `black` handles that
extend-ignore = E501
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to change the max line length, as IDEs may be using this value to discourage long line lengths in the first place.

@davehunt
Copy link
Collaborator

Could you also add a badge to the README to indicate the project uses black?

@davehunt davehunt merged commit ea28067 into pytest-dev:master Nov 13, 2018
@BeyondEvil BeyondEvil deleted the blacked branch November 13, 2018 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants