Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py312 #70

Merged
merged 5 commits into from
Oct 4, 2023
Merged

py312 #70

merged 5 commits into from
Oct 4, 2023

Conversation

okken
Copy link
Contributor

@okken okken commented Oct 4, 2023

No description provided.

@okken
Copy link
Contributor Author

okken commented Oct 4, 2023

@nicoddemus A few questions:

  1. Do you want me to tag you (or someone else, maybe @RonnyPfannschmidt) as the reviewer for all PRs, just PRs I'd like feedback on, or not at all?
    example: this PR seems pretty basic and not needing review.
  2. CI is set up for testing all versions on both windows and ubuntu. Is that overkill? Ubuntu enough? Or maybe just latest on windows (if possible)?
  3. Tox is testing against old versions of pytest, CI is not. Is the tox testing against old versions of pytest overkill? If not, I'll probably try to add it to CI also.

Also, thanks for your patience and assistance with this project and onboarding me.

Thanks

@nicoddemus
Copy link
Member

Do you want me to tag you (or someone else, maybe @RonnyPfannschmidt) as the reviewer for all PRs, just PRs I'd like feedback on, or not at all?

I would prefer only if you would like specific feedback from me, thanks.

CI is set up for testing all versions on both windows and ubuntu. Is that overkill? Ubuntu enough? Or maybe just latest on windows (if possible)?

I particularly prefer to always test all version in all platforms, specially if the cost is just a couple of extra minutes, but feel free to change that if it will simplify your workflow.

Tox is testing against old versions of pytest, CI is not. Is the tox testing against old versions of pytest overkill? If not, I'll probably try to add it to CI also.

If a plugin declares support for some minimum pytest version (say 5.0+), I think it is important to test against that pytest version, at least with 1 compatible Python version (latest is fine). For the rest of the tests, running against latest pytest and all supported Python versions is good enough I think.

@okken
Copy link
Contributor Author

okken commented Oct 4, 2023

Thanks @nicoddemus

@okken okken merged commit 394cf77 into pytest-dev:master Oct 4, 2023
18 checks passed
@okken okken deleted the okken_py312 branch October 9, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants