setup.py removal #72
Merged
setup.py removal #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okken
commented
Oct 9, 2023
pyproject.toml
Outdated
| requires = ["setuptools>=40.8.0", "wheel", "setuptools_scm"] | ||
| build-backend = 'setuptools.build_meta' | ||
| build-backend = "setuptools.build_meta" | ||
| requires = [ "setuptools>=60", "setuptools_scm>=7"] |
There was a problem hiding this comment.
@RonnyPfannschmidt setuptools_scm 8 was breaking Python 3.7, so I kept setuptools_scm 7
okken
commented
Oct 9, 2023
| 3. Push the branch to `upstream`. | ||
| 4. Once all tests pass, merge the PR. | ||
| 5. Once the PR completes, create a Release with a new version tag on GitHub. | ||
| Version should be in the form of "vx.y.z". ex: v0.9.2 |
There was a problem hiding this comment.
These steps were tested on a diff project, and I'm hoping to try this out on this project.
okken
requested review from
RonnyPfannschmidt
and removed request for
RonnyPfannschmidt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous merge attempt had a merge conflict
fixes #64