Headless Firefox

[mpasternak]

Hi,

after splinter gets the change from cobrateam/splinter#677 commited, this patch will give you headless Firefox.

[coveralls]

Coverage decreased (-0.09%) to 87.41% when pulling 7084d38 on mpasternak:master into e6af25a on pytest-dev:master.

[bubenkoff]

@mpasternak as it's merged looks like, will you bump the splinter version up in the requirements?

[mpasternak]

@bubenkoff I'd love to, but the version in splinter repo is 0.13.0 (changed 4 months ago) and it is also the latest version on PyPI. I guess the next pytest-splitner version will be 0.13.1 or 0.14.0. Looks like I need to change pytest-splinter requirements to "splinter>0.13.0", is that okay with you? This will effectively block working releases of pytest-splinter until splinter gets the new release done...

[mpasternak]

@bubenkoff Hey, how are things. Any progress on this issue? Looks like someone else also submitted a PR about --headless for Firefox...

[bubenkoff]

sorry for the late response, on your question about splinter>0.13.0 -> definitely a good idea then, please proceed

[mpasternak]

Splinter version bumped, please re-review

[bubenkoff]

please add a changelog record and add yourself to authors

[bubenkoff]

please add a changelog record and add yourself to the authors and resolve the conflicts

[mpasternak]

@bubenkoff Done, thanks

[bubenkoff]

@mpasternak broken tests?

[bubenkoff]

@mpasternak also looks like in the PR it displays the changes which are already in master

[mpasternak]

What do you mean "PR displays changes which are already in master"?

I remember that I saw some headless Firefox patches merged from #123 , are those this changes you're talking about?

I did --rebase, but I don't have much experience with it. If there's anything that I broke let me know. Should I remove my fork and re-apply those patches?

[bubenkoff]

if you look here: https://github.com/pytest-dev/pytest-splinter/pull/144/files, you'll see the changes definitely not made by you
so please rebase your branch correctly
https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

[bubenkoff]

@mpasternak linters still fail - the easiest fix is just to run black over the code:

black tests pytest_splinter

[mpasternak]

TBH this trivial and small change because of my lack of knowledge how rebase works grew up to be a much harder problem.

Would you suggest re-starting this branch again from scratch or is it still salvageable at this point? What's your idea on that?

[zupo]

@mpasternak: if you give me (zupo) push permissions on your fork, I can try doing the rebasing for you.

[bubenkoff]

@mpasternak tests are failing please check

[zupo]

I've reapplied changes proposed in this PR on top of latest master and opened a new PR: #152

[mpasternak]

Thanks @zupo, I hope this gets committed

[bubenkoff]

implemented in 3.3.0