-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve behavior of --numprocesses=auto and --pdb #415
Improve behavior of --numprocesses=auto and --pdb #415
Conversation
59e05b7
to
28cf4d6
Compare
28cf4d6
to
61131f7
Compare
61131f7
to
d8a794b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @jirikuncar!
@nicoddemus is it necessary to fix the AppVeyor failures [1]? [1] https://ci.appveyor.com/project/pytestbot/pytest-xdist/builds/22311072/job/tpjds44asi1uy5cj |
Hi @jirikuncar, Yeah, we need to fix it as it is part of our CI. I think this is due to recent changes on how I think it is enough to change: result.stdout.fnmatch_lines(
["usage: pytest.py *", "pytest.py: error: my_usage_error"]
) to: result.stdout.fnmatch_lines(
["*usage: pytest.py *", "pytest.py: error: my_usage_error"]
) I will push a commit to that effect, let's see. 👍 |
Fixed linting, should be OK now. 👍 |
Thanks a ton @jirikuncar for the PR! |
Nice, thanks! |
I was getting annoyed by changing
pytest -ff -n=auto ...
command when I wanted to append only--pdb
. With this PR one can use-n=auto
and anytime simply append--pdb
without getting theUsageError
.