New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-10113/Change error message #10145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks Jennifer!
Head branch was pushed to by a user without write access
That seems like it would now make the error message confusing for the far more common case, when there indeed is a test which wasn't found... |
@The-Compiler would you like to decline the PR then? |
@The-Compiler - it's been a year, let's either merge this or close it and close the issue as wontfix. |
Sorry for the radio silence, this got lost in my inbox with all the Europython stuff 😅 I still think that in the common case of:
"not found" makes things clearer vs. "couldn't collect" (after all, the collection did work!). As shown in #10113 (comment) I believe the existing error message is sufficient for this far more exotic case. Thus I'm closing this - thanks for the contribution anyways though, @jekwatt, and sorry for the loooong delay! |
Fixes #10113.