Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize ANSI markup on all terminal output sections #10269

Open
jeffwright13 opened this issue Sep 4, 2022 · 5 comments
Open

Standardize ANSI markup on all terminal output sections #10269

jeffwright13 opened this issue Sep 4, 2022 · 5 comments
Labels
topic: reporting related to terminal output and user-facing messages and errors type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature

Comments

@jeffwright13
Copy link

Currently (7.2.0.dev264+g6ad32a9c5), the console heading for some sections is colorized ('warnings', 'short test summary info'); while other sections are not (ERRORS, FAILURES, PASSES, and 'rerun test summary info' if the pytest-rerunfailures plugin is installed). Also, the 'test session starts' and 'short test summary info' sections are in bold, while none of the others are.

Enhancement request is to standardize ANSI markup for the various sections. If it were up to me, I would simply add colors to the section headings that are not colored: PASSES (green), FAILURES (red), ERRORS (yellow).

Screen Shot 2022-09-04 at 5 26 52 PM

Screen Shot 2022-09-04 at 5 27 14 PM

@Zac-HD Zac-HD added type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature topic: reporting related to terminal output and user-facing messages and errors labels Sep 13, 2022
@doublevcodes
Copy link
Contributor

Hello, can I attempt this?

@nicoddemus
Copy link
Member

@doublevcodes sure! Btw no need to ask for permission to tackle issues which are not assigned, feel free to go ahead. 👍 😁

@jeffwright13
Copy link
Author

@doublevcodes - if you would like help reproducing the above issue (i.e. if you want to run those tests), let me know. They are basically taken from https://github.com/jeffwright13/pytest-tui/tree/main/demo-tests.

@doublevcodes
Copy link
Contributor

I've had a look at the demo tests and I understand the problem but since I'm relatively new to the purest codebase, could someone potentially point me to the sections of code I'll be working with?

@RonnyPfannschmidt
Copy link
Member

It should be largely contained in the terminalwriter

It's likely some preparing cleanup is necessarily

It would be nice if we could prepare the code for eventual direct integration of stuff like the ide plugins for testing and pytest-TUI

Terminalwriter has a lot of painful legacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: reporting related to terminal output and user-facing messages and errors type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature
Projects
None yet
Development

No branches or pull requests

5 participants