Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TerminalWriter public API? #10436

Open
The-Compiler opened this issue Oct 26, 2022 · 3 comments
Open

Make TerminalWriter public API? #10436

The-Compiler opened this issue Oct 26, 2022 · 3 comments
Labels
type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature

Comments

@The-Compiler
Copy link
Member

Looking at the fallout of the py dropping, it seems like one recurrent issue is that people create their own py.io.TerminalWriter:

...and probably a lot more!

sooo... I wonder if we should make it public API of some kind, given how it's used like one even in pytest-dev plugins?

@nicoddemus
Copy link
Member

Not sure, we probably don't want to encourage users to use that, given we want to eventually drop TerminalWriter in favor of something else (unless I'm wrong in that aspect).

@RonnyPfannschmidt
Copy link
Member

Given the capture interaction, its a minefield, nobody should construct them

@Zac-HD Zac-HD added the type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature label Oct 27, 2022
@asottile
Copy link
Member

Config.get_terminal_writer exists -- though afaict it's undocumented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: proposal proposal for a new feature, often to gather opinions or design the API around the new feature
Projects
None yet
Development

No branches or pull requests

5 participants