Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example in "The new config.cache object" #11065

Closed
CarstenGrohmann opened this issue Jun 1, 2023 · 2 comments · Fixed by #11542
Closed

Update example in "The new config.cache object" #11065

CarstenGrohmann opened this issue Jun 1, 2023 · 2 comments · Fixed by #11542
Labels
type: docs documentation improvement, missing or needing clarification

Comments

@CarstenGrohmann
Copy link
Contributor

Hi pytest developers,

in the API documentation for config.cache you wrote that the access should be done with the pytestconfig fixture. But in the example in The new config.cache object you use the request fixture.

Please consider updating the example to be consistent with the API documentation.

Thank you,
Carsten
@The-Compiler
Copy link
Member

pytestconfig and request.config both result in the same thing. But I agree it'd make sense to be consistent there - do you want to open a pull request?

@The-Compiler The-Compiler added the type: docs documentation improvement, missing or needing clarification label Jun 1, 2023
@CarstenGrohmann
Copy link
Contributor Author

ok, I'll open a PR.

@CarstenGrohmann CarstenGrohmann mentioned this issue Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: docs documentation improvement, missing or needing clarification
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use pytestconfig instead of request.config in cache example
2 participants
@The-Compiler @CarstenGrohmann