New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated getfuncargvalue in doctest #1898

Closed
ViviCoder opened this Issue Sep 1, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@ViviCoder

ViviCoder commented Sep 1, 2016

When testing a package with pytest 3, I get a deprecation error due to the use of getfuncargvalue in doctest. The interesting part of the trace is:

self = DoctestItem 'astroquery.utils.url_helpers.urljoin_keep_path'

    def setup(self):
        if self.dtest is not None:
            self.fixture_request = _setup_fixtures(self)
            globs = dict(getfixture=self.fixture_request.getfixturevalue)
>           for name, value in self.fixture_request.getfuncargvalue('doctest_namespace').items():

/usr/lib/python2.7/dist-packages/_pytest/doctest.py:91: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <FixtureRequest for <DoctestItem 'astroquery.utils.url_helpers.urljoin_keep_path'>>
argname = 'doctest_namespace'

    def getfuncargvalue(self, argname):
        """ Deprecated, use getfixturevalue. """
        from _pytest import deprecated
        warnings.warn(
            deprecated.GETFUNCARGVALUE,
>           DeprecationWarning)
E       DeprecationWarning: use of getfuncargvalue is deprecated, use getfixturevalue

/usr/lib/python2.7/dist-packages/_pytest/fixtures.py:446: DeprecationWarning

Here is a full log file: pytest_log.txt

@nicoddemus

This comment has been minimized.

Member

nicoddemus commented Sep 1, 2016

Thanks for the report!

@nicoddemus nicoddemus closed this in 4e58c9a Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment