Show multiple issue links in CHANGELOG entries

[mihaic]

Restores the functionality removed in PR #2488.

• Add a new news fragment into the changelog folder
  • name it $issue_id.$type for example (588.bug)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
• Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
• Make sure to include reasonable tests for your change if necessary

Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:

• Add yourself to AUTHORS;

[nicoddemus]

Thanks!

I removed it because I didn't see much value in it and it complicates the template a bit. Can you describe some cases where this is useful?

I'm not opposed to accept this, I'm just curious. 👍

[mihaic]

I had not realized you removed it on purpose. It seems useful when a feature is added via multiple PRs or when a bug is not completely fixed by an issue and a second issue is created for a corner case, all within the same release cycle.

[coveralls]

Coverage remained the same at 92.059% when pulling 10ded39 on mihaic:multiple-issues-in-changelog into dd294aa on pytest-dev:master.

[nicoddemus]

It seems useful when a feature is added via multiple PRs or when a bug is not completely fixed by an issue and a second issue is created for a corner case, all within the same release cycle.

I see, just thought the mechanism to group them was a little brittle, which is to have the exact same text for it; seems easy to inadvertently fix a typo or something and make the issue appear in separate entries because of that.

As I said I don't oppose adding it back though if others think this is useful. 👍

[RonnyPfannschmidt]

looks good 👍

[nicoddemus]

Just tried the PR, here's the resulting changelog: https://gist.github.com/nicoddemus/fb844dade0c4b14a1fd49b5cdb00d6ce

Thanks again @mihaic