get PYTEST_ADDOPTS before calling _initini #2824
Conversation
|
I added a test in 5bcdb52 - without the patch it fails - with the patch it passes. |
testing/test_config.py
Outdated
| @@ -843,3 +843,10 @@ def test_with_existing_file_in_subdir(self, tmpdir): | |||
| rootdir, inifile, inicfg = determine_setup(None, ['a/exist']) | |||
| assert rootdir == tmpdir | |||
| assert inifile is None | |||
|
|
|||
| def test_addopts_before_initini(self, testdir, tmpdir, monkeypatch): | |||
| monkeypatch.setenv('PYTEST_ADDOPTS', '-o cache_dir=/somewhere') | |||
There was a problem hiding this comment.
good thinking, for more pedantic separation i propose to replace the arbitrarily chosen /somewhere by using testdir.join('somewhere')
There was a problem hiding this comment.
Done in 48c31f9. I had to use testdir.tmpdir.join(...) though.
|
Shouldn't we target |
|
good call, lets re-target this to features |
|
I updated the PR to target the Just out of curiosity: what is roughly the timeline the changes on the |
|
the features branch is for minor versions primarily, we dont have a clear schedule as of now |
…on Windows We use shlex to parse command-line arguments and PYTEST_ADDOPTS, so passing a full path with '\' arguments produces incorrect results on Windows Anyway users are advised to use relative paths for portability
While it works to pass
-o cache_dir=/somewhereas command line arguments or set the option in thesetup.cfgfile I tried to achieve the same by setting the environment variablePYTEST_ADDOPTS="-o cache_dir=/somewhere". This doesn't work atm since the variable is only being considered after Config._initini has been called which e.g. decides on theoverride_ini.To enable this use case this patch moves the call to
Config._initinibehind getting the environment variablePYTEST_ADDOPTS. I didn't see any negative side effects of this change but I am new topytestso might be missing something.I haven't added a test for this since I thought getting feedback in the patch first makes sense. If a test is desired please let me know and I am happy to do so.
I targeted
mastersince the change is trivial. Please let me know if I should targetfeaturesinstead.