Additionally handle logstart and logfinish hooks #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0undt3ch
force-pushed
the
feature/logstart-logfinish
branch
from
e98ae1f
to
4eccf4d
Compare
s0undt3ch
force-pushed
the
feature/logstart-logfinish
branch
from
4eccf4d
to
23c15f9
Compare
nicoddemus
approved these changes
Feb 5, 2018
twmr
suggested changes
Feb 5, 2018
| @@ -371,18 +371,20 @@ def _runtest_for(self, item, when): | |||
| formatter=self.formatter, level=self.log_level) as log_handler: | |||
| if self.log_cli_handler: | |||
| self.log_cli_handler.set_when(when) | |||
There was a problem hiding this comment.
I would add the following code here and remove your if item checks:
if item is None:
yield
return
|
Thx for working on this! |
s0undt3ch
force-pushed
the
feature/logstart-logfinish
branch
from
a2369c3
to
c9123c6
Compare
|
@nicoddemus sorry, I force pushed the changes asked by @thisch and lost your change log changes(forgot to pull first). |
No worries, just pushed my change again. 👍 |
|
Thanks! |
s0undt3ch
force-pushed
the
feature/logstart-logfinish
branch
from
8abc7a4
to
a8ac48c
Compare
twmr
reviewed
Feb 6, 2018
_pytest/logging.py
Outdated
| if not hasattr(item, 'catch_log_handlers'): | ||
| item.catch_log_handlers = {} | ||
|
|
There was a problem hiding this comment.
This newline and the next one are not really needed. Can you remove them please?
s0undt3ch
force-pushed
the
feature/logstart-logfinish
branch
from
a8ac48c
to
ea06c13
Compare
twmr
approved these changes
Feb 6, 2018
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
$issue_id.$typefor example (588.bugfix)removal,feature,bugfix,vendor,docortrivialbugfix,vendor,docortrivialfixes, targetmaster; for removals or features targetfeatures;Unless your change is a trivial or a documentation fix (e.g., a typo or reword of a small section) please:
AUTHORS, in alphabetical order;