Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all items from cluster #63

Merged
merged 4 commits into from
Feb 4, 2023
Merged

Conversation

jacksturt
Copy link
Contributor

In version 2.13, if you copy the example_ws_usage.ts code, both PythCluster and getPythClusterApiUrl are not defined. This is because they are not exported in the index.ts. This request adds those exports.

@guibescos
Copy link
Contributor

guibescos commented Feb 3, 2023

Looks good to me, I've been successful with import {PythCluster} from "@pythnetwork/client/lib/cluster"; but having it in index.ts makes sense

src/index.ts Show resolved Hide resolved
@jacksturt
Copy link
Contributor Author

I also updated the changelog, but the npm version command isn't working for me.

@guibescos
Copy link
Contributor

Can you bump the package version in package.json and rerun npm install and commit package-lock.json

@jacksturt
Copy link
Contributor Author

Updated!

@guibescos guibescos merged commit f827e04 into pyth-network:main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants