Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle NaN losses and add a test, closes #145 #151

Merged
merged 1 commit into from
Feb 15, 2019
Merged

handle NaN losses and add a test, closes #145 #151

merged 1 commit into from
Feb 15, 2019

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Feb 14, 2019 •
edited
Loading

This reverts the behavior that we've decided upon a long time ago.

The bug was introduced a few months ago.

@basnijholt basnijholt changed the base branch from master to stable-0.7 February 14, 2019 12:42
jbweston
jbweston approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@basnijholt basnijholt merged commit 386da45 into stable-0.7 Feb 15, 2019
@jbweston jbweston deleted the nan_loss branch February 16, 2019 08:44
@basnijholt basnijholt mentioned this pull request Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbweston jbweston jbweston approved these changes

@akhmerov akhmerov Awaiting requested review from akhmerov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basnijholt @jbweston