Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite fails with pytest 8 #1233

Closed
hynek opened this issue Feb 2, 2024 · 0 comments · Fixed by #1249
Closed

Test suite fails with pytest 8 #1233

hynek opened this issue Feb 2, 2024 · 0 comments · Fixed by #1249
Labels
Good for New Contributors

Comments

@hynek
Copy link
Member

hynek commented Feb 2, 2024

We've got a bunch of failing tests; all in the sphere of exceptions and warnings: https://github.com/python-attrs/attrs/actions/runs/7759031210
@hynek hynek mentioned this issue Feb 3, 2024
Closed
halstead pushed a commit to yoctoproject/poky that referenced this issue Feb 16, 2024
@moto-timo @rpurdie
python3-attrs: skip test failing with pytest-8
f5a92e1 
tests/test_funcs.py test_unknown test case is failing with
pytest 8. Skip it for now until upstream has a fix.

python-attrs/attrs#1233

(From OE-Core rev: 99d6b973580fe5d96a92f97cdfbdaeb6008306d5)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to openembedded/openembedded-core that referenced this issue Feb 16, 2024
@moto-timo @rpurdie
python3-attrs: skip test failing with pytest-8
99d6b97 
tests/test_funcs.py test_unknown test case is failing with
pytest 8. Skip it for now until upstream has a fix.

python-attrs/attrs#1233

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to yoctoproject/poky that referenced this issue Feb 16, 2024
@moto-timo @rpurdie
python3-attrs: skip test failing with pytest-8
7b335d7 
tests/test_funcs.py test_unknown test case is failing with
pytest 8. Skip it for now until upstream has a fix.

python-attrs/attrs#1233

(From OE-Core rev: 99d6b973580fe5d96a92f97cdfbdaeb6008306d5)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to yoctoproject/poky that referenced this issue Feb 16, 2024
@moto-timo @rpurdie
python3-attrs: skip test failing with pytest-8
6b353df 
tests/test_funcs.py test_unknown test case is failing with
pytest 8. Skip it for now until upstream has a fix.

python-attrs/attrs#1233

(From OE-Core rev: 99d6b973580fe5d96a92f97cdfbdaeb6008306d5)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to yoctoproject/poky that referenced this issue Feb 17, 2024
@moto-timo @rpurdie
python3-attrs: skip test failing with pytest-8
f3a327b 
tests/test_funcs.py test_unknown test case is failing with
pytest 8. Skip it for now until upstream has a fix.

python-attrs/attrs#1233

(From OE-Core rev: 99d6b973580fe5d96a92f97cdfbdaeb6008306d5)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to yoctoproject/poky that referenced this issue Feb 17, 2024
@moto-timo @rpurdie
python3-attrs: skip test failing with pytest-8
16805ba 
tests/test_funcs.py test_unknown test case is failing with
pytest 8. Skip it for now until upstream has a fix.

python-attrs/attrs#1233

(From OE-Core rev: 99d6b973580fe5d96a92f97cdfbdaeb6008306d5)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to yoctoproject/poky that referenced this issue Feb 17, 2024
@moto-timo @rpurdie
python3-attrs: skip test failing with pytest-8
fefea5c 
tests/test_funcs.py test_unknown test case is failing with
pytest 8. Skip it for now until upstream has a fix.

python-attrs/attrs#1233

(From OE-Core rev: 99d6b973580fe5d96a92f97cdfbdaeb6008306d5)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to yoctoproject/poky that referenced this issue Feb 17, 2024
@moto-timo @rpurdie
python3-attrs: skip test failing with pytest-8
3b9dbfb 
tests/test_funcs.py test_unknown test case is failing with
pytest 8. Skip it for now until upstream has a fix.

python-attrs/attrs#1233

(From OE-Core rev: 5af87eda524bb0affe207c006f67b4191f6ce746)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to openembedded/openembedded-core that referenced this issue Feb 17, 2024
@moto-timo @rpurdie
python3-attrs: skip test failing with pytest-8
5af87ed 
tests/test_funcs.py test_unknown test case is failing with
pytest 8. Skip it for now until upstream has a fix.

python-attrs/attrs#1233

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
dlax added a commit to dlax/attrs that referenced this issue Feb 28, 2024
@dlax
Remove pytest.deprecated_call() in TestAssoc::test_unknown
393176a 
assoc() no longer raises a deprecation warning since commit
22ae847 but the 'with
pytest.deprecated_call():' in that test was not removed then (in
contrast with other test cases).

Maybe this got unnoticed due to a pytest bug?
In any case, using pytest 8+ (and keeping deprecated_call()) shows that
no warning is raised and the test fails.

Removing the upper bound on pytest in dev dependencies as tests now
pass with pytest 8.0.

Fix python-attrs#1233.
@dlax dlax mentioned this issue Feb 28, 2024
Merged
12 tasks
dlax added a commit to dlax/attrs that referenced this issue Feb 28, 2024
@dlax
Remove pytest.deprecated_call() in TestAssoc::test_unknown
59b4b3e 
assoc() no longer raises a deprecation warning since commit
22ae847 but the 'with
pytest.deprecated_call():' in that test was not removed then (in
contrast with other test cases).

Maybe this got unnoticed due to a pytest bug?
In any case, using pytest 8+ (and keeping deprecated_call()) shows that
no warning is raised and the test fails.

Removing the upper bound on pytest in dev dependencies as tests now
pass with pytest 8.0.

Fix python-attrs#1233.
github-merge-queue bot pushed a commit that referenced this issue Mar 2, 2024
@dlax @hynek
Remove pytest.deprecated_call() in TestAssoc::test_unknown (#1249)
b9084fa 
assoc() no longer raises a deprecation warning since commit
22ae847 but the 'with
pytest.deprecated_call():' in that test was not removed then (in
contrast with other test cases).

Maybe this got unnoticed due to a pytest bug?
In any case, using pytest 8+ (and keeping deprecated_call()) shows that
no warning is raised and the test fails.

Removing the upper bound on pytest in dev dependencies as tests now
pass with pytest 8.0.

Fix #1233.

Co-authored-by: Hynek Schlawack <hs@ox.cx>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@moto-timo @rpurdie
src/poky:python3-attrs: skip test failing with pytest-8
b1ab9f6 
tests/test_funcs.py test_unknown test case is failing with
pytest 8. Skip it for now until upstream has a fix.

python-attrs/attrs#1233

(From OE-Core rev: 5af87eda524bb0affe207c006f67b4191f6ce746)

Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good for New Contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove pytest.deprecated_call() in TestAssoc::test_unknown dlax/attrs
2 participants
@hynek @webknjaz