Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest.deprecated_call() in TestAssoc::test_unknown #1249

Merged
merged 2 commits into from
Mar 2, 2024

Conversation

dlax
Copy link
Contributor

@dlax dlax commented Feb 28, 2024

Summary

assoc() no longer raises a deprecation warning since commit 22ae847 but the with pytest.deprecated_call(): in that test was not removed then (in contrast with other test cases).

Maybe this got unnoticed due to a pytest bug?
In any case, using pytest 8+ (and keeping deprecated_call()) shows that no warning is raised and the test fails.

Removing the upper bound on pytest in dev dependencies as tests now pass with pytest 8.0.

Fix #1233.

Pull Request Check List

  • Do not open pull requests from your main branch – use a separate branch!
    • There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
    • This is not a pre-requisite for your your pull request to be accepted, but you have been warned.
  • Added tests for changed code.
    Our CI fails if coverage is not 100%.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
    • If they've been added to attr/__init__.pyi, they've also been re-imported in attrs/__init__.pyi.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • [ x Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      The next version is the second number in the current release + 1.
      The first number represents the current year.
      So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
      If the next version is the first in the new year, it'll be 23.1.0.
  • Documentation in .rst and .md files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

assoc() no longer raises a deprecation warning since commit
22ae847 but the 'with
pytest.deprecated_call():' in that test was not removed then (in
contrast with other test cases).

Maybe this got unnoticed due to a pytest bug?
In any case, using pytest 8+ (and keeping deprecated_call()) shows that
no warning is raised and the test fails.

Removing the upper bound on pytest in dev dependencies as tests now
pass with pytest 8.0.

Fix python-attrs#1233.
@dlax dlax marked this pull request as ready for review February 28, 2024 13:40
@hynek hynek enabled auto-merge March 2, 2024 06:40
Copy link
Member

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great – thank you!

@hynek hynek added this pull request to the merge queue Mar 2, 2024
Merged via the queue into python-attrs:main with commit b9084fa Mar 2, 2024
20 checks passed
@dlax dlax deleted the pytest-8 branch March 2, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test suite fails with pytest 8
2 participants