Improve (de)serialization and validation capabilities #653

sscherfke · 2020-06-17T19:49:54Z

Improve (de)serialization and validation capabilities by adding hooks that can automatically update a class’ attributes and that can change the way how objects are serialized by asdict().

See: #649

Pull Request Check List

This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

wsanchez · 2020-06-17T20:20:27Z

tests/test_make.py

+        def hook(name, ca, type):
+            ca.converter = type


Hrm… if I were writing a hook like this, I'd be type hinting everything, and the type of ca here is _CountingAttr, which is private. That seems like a problem.

IIRC we've avoided making _CountingAttr public, so this API would require us to at least define an interface, no?

Yes, that’s true. I also stumbled upon this when I was writing the docstring. Making an Interface seems like a reasonable idea. We wouldn’t to expose the actual _CountingAttr than but mypy would be happy nonetheless.

sscherfke · 2020-06-17T20:43:03Z

I have a lot more uncommited code, but some (important) parts of it require at least Python 3.6.

When are you planning to drop support for Python 2 (and maybe even 3.5)? This would make a few things easier and if that’s not too far into the future, I would gladly wait a little. :)

wsanchez · 2020-06-17T21:18:27Z

When are you planning to drop support for Python 2 (and maybe even 3.5)? This would make a few things easier and if that’s not too far into the future, I would gladly wait a little. :)

I suggest you file an Issue called "[RFC] Drop support for Python 2" and have that discussion there, as it's not specific to this ticket. (And perhaps another for 3.5.)

hynek · 2020-06-18T06:39:38Z

I'm sorry I'm offline for the next week, but there's been a feature request asking for _CountingAttr to become public already so this might be two birds with one stone.

As for Python 2: https://www.attrs.org/en/stable/python-2.html

As much as I don't like it, it's one of our main features over dataclasses ATM.

Once we go Python 3-only, it will definitely not be 3.5. :)

sscherfke · 2020-07-07T19:10:14Z

What is your preferred approach for tests that run (and parse) only with python 3.6 and above?

hynek · 2020-07-08T08:32:53Z

attrs/conftest.py

Line 17 in 3e3d842

if sys.version_info[:2] < (3, 6):

sscherfke · 2020-07-09T21:15:05Z

This PR will only focus on the hooks. I have removed the converters and validators and will re-propose them in another PR when this one is accepted.

sscherfke · 2020-07-12T09:44:04Z

_CountingAttr (or an interface for it) need to be made public for this PR.

What would be your prefered approach? Create a new Interface that _CountingAttr inherits or rename _CountingAttr to CountingAttr? Should also be imported in __init__.py in that case?

wsanchez · 2020-07-13T18:48:57Z

_CountingAttr (or an interface for it) need to be made public for this PR.

What would be your prefered approach? Create a new Interface that _CountingAttr inherits or rename _CountingAttr to CountingAttr? Should also be imported in __init__.py in that case?

Again, we've resisted making _CountingAttr in the past because it's not an API we want to commit to long-term, so an interface that is limited to what we are willing to support seems best, leaving _CountingAttr itself as an implementation detail.

That assumes that @hynek is amenable to the resulting public interface.

hynek · 2020-07-13T18:53:43Z

The main issue here is that I don't want it to be "counting" anymore if not necessary (ordered dicts), cf #643. I guess we'll have to extract a sub-interface?

sscherfke · 2020-07-13T18:56:36Z

An Interface would suffice since it will (at least in this PR) only be used for documentation and (mypy) typing. I can try to extract an Interface.

sscherfke · 2020-07-14T19:59:48Z

Hm, _CountingAttr is so "simple" and specific, that I don’t know which attributes/meths to extract into an interface.

wsanchez · 2020-07-16T20:44:30Z

Hm, _CountingAttr is so "simple" and specific, that I don’t know which attributes/meths to extract into an interface.

I'd start with: what exactly is the minimum needed for this PR to function?

sscherfke · 2020-07-16T21:04:08Z

I only want to add a converter to the attrib, but instances of _CountingAttr (I’d call the interface MutableAttr since it is, in contrast to Attribute, mutable) are passed to the hook so it would not be very long-sighted to only add the converter attribute to the interface. I think at least converter, metadata, validator() and default() should be made public. Changing the other attributes in the hook might not make too much sense.

hynek · 2020-07-20T07:23:29Z

I guess a fairer name would be AttributeDefinition but I wonder if we couldn't spin it in a way that the hook receives Attributes but is free to replace them with something else? The would be definitely cleaner and less invasive.

sscherfke · 2020-07-20T17:19:58Z

I’m not sure if I understand what you mean. The whole purpose of the hook is to be invasive and let the user mess with the attribute definition.

hynek · 2020-07-20T17:25:18Z

I mean that due to stuff like resolving decorator-based defaults and validators we can’t really provide a good interface? My hope would be that the hook would get a list of Attributes will fully resolved validators etc and would return a list of Attributes that may replace some of them or even remove some?

sscherfke · 2020-07-20T20:53:10Z

Thanks for the clarification. I will think about this and see if it works.

hynek · 2020-07-21T06:14:53Z

Yeah, please let me know what you think. The upsides are mainly that we don’t have to introduce a new “in-between type” that would have to be mutated by the users. That smells like bugs and edge cases to me. I’m open to add more helper APIs to Attribute, though!

sscherfke · 2020-07-23T19:35:05Z

This was an excelent idea of you, @hynek. :) The hook is now purely functional. It takes an Attribute and returns an Attribute. The only thing that we’d need to change now is to make Attribute._assoc public in order to allow people to evolve an attribute.

sscherfke · 2020-09-25T07:57:13Z

ping 🐈

hynek · 2020-09-25T16:10:49Z

ping 🐈

Current status:

😇

sscherfke · 2020-09-25T17:57:37Z

Oh, I thought you’re already back. Then have a lot of fun and I’ll be patient! 🏄

hynek

A lot of nitpicking but thanks to the magic of suggestions, it should be quick to get thru!

collapses on the floor

changelog.d/653.change.rst

docs/extending.rst

tests/test_hooks.py

sscherfke · 2020-10-14T07:52:05Z

Ohai, this is the weekly ping. 🙊

hynek

We should change _assoc to evolve, not assoc but I’ll do it myself, to not delay this any further. Thanks and thank you for the patience, this is a big one!

sscherfke · 2020-10-15T09:41:27Z

Thanks for merging! ❤️

Next PR will arrive shortly 😬

Bumps [attrs](https://github.com/python-attrs/attrs) from 20.2.0 to 20.3.0. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/python-attrs/attrs/releases">attrs's releases</a>. <blockquote> <h2>20.3.0</h2> <h2>Backward-incompatible Changes</h2> <ul> <li> <code>attr.define()</code>, <code>attr.frozen()</code>, <code>attr.mutable()</code>, and <code>attr.field()</code> remain provisional. This release does not change change anything about them and they are already used widely in production though. If you wish to use them together with mypy, you can simply drop <a href="https://gist.github.com/hynek/1e3844d0c99e479e716169034b5fa963#file-attrs_ng_plugin-py">this plugin</a> into your project. Feel free to provide feedback to them in the linked issue <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a>. We will release the <code>attrs</code> namespace once we have the feeling that the APIs have properly settled. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a> </li> </ul> <h2>Changes</h2> <ul> <li><code>attr.s()</code> now has a field_transformer hook that is called for all <code>Attribute</code>s and returns a (modified or updated) list of <code>Attribute</code> instances. <code>attr.asdict()</code> has a value_serializer hook that can change the way values are converted. Both hooks are meant to help with data (de-)serialization workflows. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/653">#653</a></li> <li><code>kw_only=True</code> now works on Python 2. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/700">#700</a></li> <li><code>raise from</code> now works on frozen classes on PyPy. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/703">#703</a>, <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/712">#712</a></li> <li><code>attr.asdict()</code> and <code>attr.astuple()</code> now treat <code>frozenset</code>s like <code>set</code>s with regards to the retain_collection_types argument. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/704">#704</a></li> <li>The type stubs for <code>attr.s()</code> and <code>attr.make_class()</code> are not missing the collect_by_mro argument anymore. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/711">#711</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/python-attrs/attrs/blob/master/CHANGELOG.rst">attrs's changelog</a>. <blockquote> <h2>20.3.0 (2020-11-05)</h2> Backward-incompatible Changes ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <ul> <li> <code>attr.define()</code>, <code>attr.frozen()</code>, <code>attr.mutable()</code>, and <code>attr.field()</code> remain provisional. This release does not change change anything about them and they are already used widely in production though. If you wish to use them together with mypy, you can simply drop <code>this plugin <https://gist.github.com/hynek/1e3844d0c99e479e716169034b5fa963#file-attrs_ng_plugin-py></code>_ into your project. Feel free to provide feedback to them in the linked issue <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a>. We will release the <code>attrs</code> namespace once we have the feeling that the APIs have properly settled. <code>[#668](python-attrs/attrs#668) <https://github.com/python-attrs/attrs/issues/668></code>_ </li> </ul> Changes ^^^^^^^ <ul> <li><code>attr.s()</code> now has a field_transformer hook that is called for all <code>Attribute</code>\ s and returns a (modified or updated) list of <code>Attribute</code> instances. <code>attr.asdict()</code> has a value_serializer hook that can change the way values are converted. Both hooks are meant to help with data (de-)serialization workflows. <code>[#653](python-attrs/attrs#653) <https://github.com/python-attrs/attrs/issues/653></code>_</li> <li><code>kw_only=True</code> now works on Python 2. <code>[#700](python-attrs/attrs#700) <https://github.com/python-attrs/attrs/issues/700></code>_</li> <li><code>raise from</code> now works on frozen classes on PyPy. <code>[#703](python-attrs/attrs#703) <https://github.com/python-attrs/attrs/issues/703></code>, <code>[#712](python-attrs/attrs#712) <https://github.com/python-attrs/attrs/issues/712></code></li> <li><code>attr.asdict()</code> and <code>attr.astuple()</code> now treat <code>frozenset</code>\ s like <code>set</code>\ s with regards to the retain_collection_types argument. <code>[#704](python-attrs/attrs#704) <https://github.com/python-attrs/attrs/issues/704></code>_</li> <li>The type stubs for <code>attr.s()</code> and <code>attr.make_class()</code> are not missing the collect_by_mro argument anymore. <code>[#711](python-attrs/attrs#711) <https://github.com/python-attrs/attrs/issues/711></code>_</li> </ul> <hr /> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/python-attrs/attrs/commit/f3762ba07bf0cec8bebdaaeca2212ba1d662ff13"><code>f3762ba</code></a> Prepare 20.3.0</li> <li><a href="https://github.com/python-attrs/attrs/commit/3d66e5727b93d3463feb0fd780ae739192e7c363"><code>3d66e57</code></a> Exclude GitHub issues from linkcheck to avoid rate limits</li> <li><a href="https://github.com/python-attrs/attrs/commit/06d0f8eda63b3f08cb5d94fff9fddf4fe6695621"><code>06d0f8e</code></a> Add funding URLs to metadata</li> <li><a href="https://github.com/python-attrs/attrs/commit/d23924f765d09f77e87a5c51c1685df0d721b469"><code>d23924f</code></a> Add provisional notice</li> <li><a href="https://github.com/python-attrs/attrs/commit/cd2f886d6372dca288abf9d999b3e35dacd9ced6"><code>cd2f886</code></a> Use 'i' and 'k' to better distinguish variables in an example (<a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/713">#713</a>)</li> <li><a href="https://github.com/python-attrs/attrs/commit/f2dabeae82c75abe174aafc7a726481ded929872"><code>f2dabea</code></a> Fix exception chaining on PyPy (<a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/712">#712</a>)</li> <li><a href="https://github.com/python-attrs/attrs/commit/6b4a1f1ce65162afe54e7101b263859bf8b2177e"><code>6b4a1f1</code></a> Tighten up mypy configuration</li> <li><a href="https://github.com/python-attrs/attrs/commit/9f7d11e415bc789c9cbab255cb9a5b8903c1b122"><code>9f7d11e</code></a> Add types to collect_by_mro annotations m(</li> <li><a href="https://github.com/python-attrs/attrs/commit/7020c8b5b55adefc76cf369fb071b1a4b15554a9"><code>7020c8b</code></a> pre-commit autoupdate</li> <li><a href="https://github.com/python-attrs/attrs/commit/56c73081c5d767e30f529ac4f15a6bdd43e23d9f"><code>56c7308</code></a> Add missing collect_by_mro to typing stubs</li> <li>Additional commits viewable in <a href="https://github.com/python-attrs/attrs/compare/20.2.0...20.3.0">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=attrs&package-manager=pip&previous-version=20.2.0&new-version=20.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end)

Bumps [attrs](https://github.com/python-attrs/attrs) from 20.2.0 to 20.3.0. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/python-attrs/attrs/releases">attrs's releases</a>. <blockquote> <h2>20.3.0</h2> <h2>Backward-incompatible Changes</h2> <ul> <li> <code>attr.define()</code>, <code>attr.frozen()</code>, <code>attr.mutable()</code>, and <code>attr.field()</code> remain provisional. This release does not change change anything about them and they are already used widely in production though. If you wish to use them together with mypy, you can simply drop <a href="https://gist.github.com/hynek/1e3844d0c99e479e716169034b5fa963#file-attrs_ng_plugin-py">this plugin</a> into your project. Feel free to provide feedback to them in the linked issue <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a>. We will release the <code>attrs</code> namespace once we have the feeling that the APIs have properly settled. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a> </li> </ul> <h2>Changes</h2> <ul> <li><code>attr.s()</code> now has a field_transformer hook that is called for all <code>Attribute</code>s and returns a (modified or updated) list of <code>Attribute</code> instances. <code>attr.asdict()</code> has a value_serializer hook that can change the way values are converted. Both hooks are meant to help with data (de-)serialization workflows. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/653">#653</a></li> <li><code>kw_only=True</code> now works on Python 2. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/700">#700</a></li> <li><code>raise from</code> now works on frozen classes on PyPy. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/703">#703</a>, <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/712">#712</a></li> <li><code>attr.asdict()</code> and <code>attr.astuple()</code> now treat <code>frozenset</code>s like <code>set</code>s with regards to the retain_collection_types argument. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/704">#704</a></li> <li>The type stubs for <code>attr.s()</code> and <code>attr.make_class()</code> are not missing the collect_by_mro argument anymore. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/711">#711</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/python-attrs/attrs/blob/master/CHANGELOG.rst">attrs's changelog</a>. <blockquote> <h2>20.3.0 (2020-11-05)</h2> Backward-incompatible Changes ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <ul> <li> <code>attr.define()</code>, <code>attr.frozen()</code>, <code>attr.mutable()</code>, and <code>attr.field()</code> remain provisional. This release does not change change anything about them and they are already used widely in production though. If you wish to use them together with mypy, you can simply drop <code>this plugin <https://gist.github.com/hynek/1e3844d0c99e479e716169034b5fa963#file-attrs_ng_plugin-py></code>_ into your project. Feel free to provide feedback to them in the linked issue <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a>. We will release the <code>attrs</code> namespace once we have the feeling that the APIs have properly settled. <code>[aio-libs#668](python-attrs/attrs#668) <https://github.com/python-attrs/attrs/issues/668></code>_ </li> </ul> Changes ^^^^^^^ <ul> <li><code>attr.s()</code> now has a field_transformer hook that is called for all <code>Attribute</code>\ s and returns a (modified or updated) list of <code>Attribute</code> instances. <code>attr.asdict()</code> has a value_serializer hook that can change the way values are converted. Both hooks are meant to help with data (de-)serialization workflows. <code>[aio-libs#653](python-attrs/attrs#653) <https://github.com/python-attrs/attrs/issues/653></code>_</li> <li><code>kw_only=True</code> now works on Python 2. <code>[aio-libs#700](python-attrs/attrs#700) <https://github.com/python-attrs/attrs/issues/700></code>_</li> <li><code>raise from</code> now works on frozen classes on PyPy. <code>[aio-libs#703](python-attrs/attrs#703) <https://github.com/python-attrs/attrs/issues/703></code>, <code>[aio-libs#712](python-attrs/attrs#712) <https://github.com/python-attrs/attrs/issues/712></code></li> <li><code>attr.asdict()</code> and <code>attr.astuple()</code> now treat <code>frozenset</code>\ s like <code>set</code>\ s with regards to the retain_collection_types argument. <code>[aio-libs#704](python-attrs/attrs#704) <https://github.com/python-attrs/attrs/issues/704></code>_</li> <li>The type stubs for <code>attr.s()</code> and <code>attr.make_class()</code> are not missing the collect_by_mro argument anymore. <code>[aio-libs#711](python-attrs/attrs#711) <https://github.com/python-attrs/attrs/issues/711></code>_</li> </ul> <hr /> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/python-attrs/attrs/commit/f3762ba07bf0cec8bebdaaeca2212ba1d662ff13"><code>f3762ba</code></a> Prepare 20.3.0</li> <li><a href="https://github.com/python-attrs/attrs/commit/3d66e5727b93d3463feb0fd780ae739192e7c363"><code>3d66e57</code></a> Exclude GitHub issues from linkcheck to avoid rate limits</li> <li><a href="https://github.com/python-attrs/attrs/commit/06d0f8eda63b3f08cb5d94fff9fddf4fe6695621"><code>06d0f8e</code></a> Add funding URLs to metadata</li> <li><a href="https://github.com/python-attrs/attrs/commit/d23924f765d09f77e87a5c51c1685df0d721b469"><code>d23924f</code></a> Add provisional notice</li> <li><a href="https://github.com/python-attrs/attrs/commit/cd2f886d6372dca288abf9d999b3e35dacd9ced6"><code>cd2f886</code></a> Use 'i' and 'k' to better distinguish variables in an example (<a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/713">#713</a>)</li> <li><a href="https://github.com/python-attrs/attrs/commit/f2dabeae82c75abe174aafc7a726481ded929872"><code>f2dabea</code></a> Fix exception chaining on PyPy (<a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/712">#712</a>)</li> <li><a href="https://github.com/python-attrs/attrs/commit/6b4a1f1ce65162afe54e7101b263859bf8b2177e"><code>6b4a1f1</code></a> Tighten up mypy configuration</li> <li><a href="https://github.com/python-attrs/attrs/commit/9f7d11e415bc789c9cbab255cb9a5b8903c1b122"><code>9f7d11e</code></a> Add types to collect_by_mro annotations m(</li> <li><a href="https://github.com/python-attrs/attrs/commit/7020c8b5b55adefc76cf369fb071b1a4b15554a9"><code>7020c8b</code></a> pre-commit autoupdate</li> <li><a href="https://github.com/python-attrs/attrs/commit/56c73081c5d767e30f529ac4f15a6bdd43e23d9f"><code>56c7308</code></a> Add missing collect_by_mro to typing stubs</li> <li>Additional commits viewable in <a href="https://github.com/python-attrs/attrs/compare/20.2.0...20.3.0">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=attrs&package-manager=pip&previous-version=20.2.0&new-version=20.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end)

`value_serializer` has been supported since this version (see: python-attrs/attrs#653)

sscherfke force-pushed the master branch from 6e2485c to 57b5c62 Compare June 17, 2020 20:00

wsanchez reviewed Jun 17, 2020

View reviewed changes

sscherfke force-pushed the master branch from 57b5c62 to 0b671aa Compare June 18, 2020 07:00

sscherfke mentioned this pull request Jun 18, 2020

Add function to "instantiate" __annotations__-derived 'attr.ib's. #424

Open

sscherfke force-pushed the master branch 2 times, most recently from 8fdcdce to 30e4359 Compare July 9, 2020 21:10

sscherfke force-pushed the master branch 2 times, most recently from 871729f to 6c0872c Compare July 12, 2020 09:22

sscherfke changed the title ~~WIP: Improve (de)serialization and validation capabilities~~ Improve (de)serialization and validation capabilities Jul 12, 2020

sscherfke changed the title ~~Improve (de)serialization and validation capabilities~~ WIP: Improve (de)serialization and validation capabilities Jul 12, 2020

sscherfke force-pushed the master branch from f76ea68 to 8114b5f Compare July 23, 2020 19:32

sscherfke requested a review from hynek September 6, 2020 15:27

sscherfke force-pushed the master branch from 3b2521d to 77b8edd Compare September 9, 2020 13:26

hynek added this to the 20.3.0 milestone Sep 14, 2020

hynek requested changes Oct 6, 2020

View reviewed changes

sscherfke force-pushed the master branch 4 times, most recently from 77e2d2e to f8dc178 Compare October 6, 2020 18:11

sscherfke requested a review from hynek October 6, 2020 18:12

Add hooks for field transformation and for asdict serialization

26c9b46

sscherfke force-pushed the master branch from 9804398 to 26c9b46 Compare October 6, 2020 18:18

Merge branch 'master' into master

6e414a3

hynek changed the title ~~WIP: Improve (de)serialization and validation capabilities~~ Improve (de)serialization and validation capabilities Oct 15, 2020

hynek approved these changes Oct 15, 2020

View reviewed changes

hynek merged commit 0eae613 into python-attrs:master Oct 15, 2020

sscherfke mentioned this pull request Oct 15, 2020

WIP: Add an auto-converter, converters and validators #701

Closed

10 tasks

hynek mentioned this pull request Oct 19, 2020

- Added auto_converters to work with auto_attribs #464

Closed

This was referenced Mar 15, 2021

Bump attrs from 19.3.0 to 20.3.0 release-engineering/exodus-lambda#127

Merged

Bump attrs from 20.1.0 to 20.3.0 CSCfi/oidc-client#27

Merged

chrisjsewell added a commit to executablebooks/sphinx-external-toc that referenced this pull request Jul 16, 2021

🔧 MAINTAIN: Update attrs minimum version

091d23a

`value_serializer` has been supported since this version (see: python-attrs/attrs#653)

chrisjsewell mentioned this pull request Jul 16, 2021

Unexpected key argument 'priority' executablebooks/jupyter-book#1394

Closed

millerdev mentioned this pull request May 9, 2022

Upgrade attrs to 21.4.0 dimagi/commcare-hq#31601

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve (de)serialization and validation capabilities #653

Improve (de)serialization and validation capabilities #653

sscherfke commented Jun 17, 2020 •

edited

Loading

wsanchez Jun 17, 2020

sscherfke Jun 17, 2020

sscherfke commented Jun 17, 2020

wsanchez commented Jun 17, 2020

hynek commented Jun 18, 2020

sscherfke commented Jul 7, 2020

hynek commented Jul 8, 2020

sscherfke commented Jul 9, 2020

sscherfke commented Jul 12, 2020

wsanchez commented Jul 13, 2020

hynek commented Jul 13, 2020

sscherfke commented Jul 13, 2020

sscherfke commented Jul 14, 2020

wsanchez commented Jul 16, 2020

sscherfke commented Jul 16, 2020

hynek commented Jul 20, 2020

sscherfke commented Jul 20, 2020

hynek commented Jul 20, 2020

sscherfke commented Jul 20, 2020

hynek commented Jul 21, 2020

sscherfke commented Jul 23, 2020

sscherfke commented Sep 25, 2020

hynek commented Sep 25, 2020 •

edited

Loading

sscherfke commented Sep 25, 2020

hynek left a comment

sscherfke commented Oct 14, 2020

hynek left a comment

sscherfke commented Oct 15, 2020

Improve (de)serialization and validation capabilities #653

Improve (de)serialization and validation capabilities #653

Conversation

sscherfke commented Jun 17, 2020 • edited Loading

Pull Request Check List

wsanchez Jun 17, 2020

Choose a reason for hiding this comment

sscherfke Jun 17, 2020

Choose a reason for hiding this comment

sscherfke commented Jun 17, 2020

wsanchez commented Jun 17, 2020

hynek commented Jun 18, 2020

sscherfke commented Jul 7, 2020

hynek commented Jul 8, 2020

sscherfke commented Jul 9, 2020

sscherfke commented Jul 12, 2020

wsanchez commented Jul 13, 2020

hynek commented Jul 13, 2020

sscherfke commented Jul 13, 2020

sscherfke commented Jul 14, 2020

wsanchez commented Jul 16, 2020

sscherfke commented Jul 16, 2020

hynek commented Jul 20, 2020

sscherfke commented Jul 20, 2020

hynek commented Jul 20, 2020

sscherfke commented Jul 20, 2020

hynek commented Jul 21, 2020

sscherfke commented Jul 23, 2020

sscherfke commented Sep 25, 2020

hynek commented Sep 25, 2020 • edited Loading

sscherfke commented Sep 25, 2020

hynek left a comment

Choose a reason for hiding this comment

sscherfke commented Oct 14, 2020

hynek left a comment

Choose a reason for hiding this comment

sscherfke commented Oct 15, 2020

sscherfke commented Jun 17, 2020 •

edited

Loading

hynek commented Sep 25, 2020 •

edited

Loading