Fix exception chaining on PyPy #712

hynek · 2020-11-04T09:05:46Z

Fixes #703

N-Coder · 2020-11-04T09:58:01Z

Looks good:

$ pypy3 -m venv venv-pypy3
$ source venv-pypy3/bin/activate
(venv-pypy3) $ pip install git+https://github.com/python-attrs/attrs.git@pypy-exc-chain
Collecting git+https://github.com/python-attrs/attrs.git@pypy-exc-chain
  Cloning https://github.com/python-attrs/attrs.git (to revision pypy-exc-chain) to /tmp/pip-req-build-fevtddhv
  Running command git clone -q https://github.com/python-attrs/attrs.git /tmp/pip-req-build-fevtddhv
  Running command git checkout -b pypy-exc-chain --track origin/pypy-exc-chain
  Switched to a new branch 'pypy-exc-chain'
  Branch 'pypy-exc-chain' set up to track remote branch 'pypy-exc-chain' from 'origin'.
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
    Preparing wheel metadata ... done
Building wheels for collected packages: attrs
  Building wheel for attrs (PEP 517) ... done
  Created wheel for attrs: filename=attrs-20.3.0.dev0-pp373-none-any.whl size=49552 sha256=26c81e0c48c2f4470901fd8cfb9b9ae6990c3d28185d6fcb8acacdefc4101a79
  Stored in directory: /tmp/pip-ephem-wheel-cache-ccltyff7/wheels/14/a6/cc/b466b3f48ab1403375e5b30128ef59ff27a61e824aa62c0bfe
Successfully built attrs
Installing collected packages: attrs
Successfully installed attrs-20.3.0.dev0
WARNING: You are using pip version 19.3.1; however, version 20.2.4 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
(venv-pypy3) $ python
Python 3.6.9 (78d4c48fa091, Apr 30 2020, 07:55:31)
[PyPy 7.3.1 with GCC 10.0.1 20200328 (Red Hat 10.0.1-0.11)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>> import attr
>>>> 
>>>> @attr.s(frozen=True, slots=True, auto_exc=True)
.... class MyException(BaseException):
....     msg:str = attr.ib()
....     
>>>> try:
....     next(iter([]))
.... except StopIteration:
....     raise MyException("test") from None
....     
Traceback (most recent call last):
  File "<stdin>", line 4, in <module>
MyException: test
>>>>

Same for CPython 3.8.6. Thanks! <3

hynek · 2020-11-04T10:02:35Z

Thank you for your quick turnaround!

Bumps [attrs](https://github.com/python-attrs/attrs) from 20.2.0 to 20.3.0. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/python-attrs/attrs/releases">attrs's releases</a>. <blockquote> <h2>20.3.0</h2> <h2>Backward-incompatible Changes</h2> <ul> <li> <code>attr.define()</code>, <code>attr.frozen()</code>, <code>attr.mutable()</code>, and <code>attr.field()</code> remain provisional. This release does not change change anything about them and they are already used widely in production though. If you wish to use them together with mypy, you can simply drop <a href="https://gist.github.com/hynek/1e3844d0c99e479e716169034b5fa963#file-attrs_ng_plugin-py">this plugin</a> into your project. Feel free to provide feedback to them in the linked issue <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a>. We will release the <code>attrs</code> namespace once we have the feeling that the APIs have properly settled. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a> </li> </ul> <h2>Changes</h2> <ul> <li><code>attr.s()</code> now has a field_transformer hook that is called for all <code>Attribute</code>s and returns a (modified or updated) list of <code>Attribute</code> instances. <code>attr.asdict()</code> has a value_serializer hook that can change the way values are converted. Both hooks are meant to help with data (de-)serialization workflows. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/653">#653</a></li> <li><code>kw_only=True</code> now works on Python 2. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/700">#700</a></li> <li><code>raise from</code> now works on frozen classes on PyPy. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/703">#703</a>, <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/712">#712</a></li> <li><code>attr.asdict()</code> and <code>attr.astuple()</code> now treat <code>frozenset</code>s like <code>set</code>s with regards to the retain_collection_types argument. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/704">#704</a></li> <li>The type stubs for <code>attr.s()</code> and <code>attr.make_class()</code> are not missing the collect_by_mro argument anymore. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/711">#711</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/python-attrs/attrs/blob/master/CHANGELOG.rst">attrs's changelog</a>. <blockquote> <h2>20.3.0 (2020-11-05)</h2> Backward-incompatible Changes ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <ul> <li> <code>attr.define()</code>, <code>attr.frozen()</code>, <code>attr.mutable()</code>, and <code>attr.field()</code> remain provisional. This release does not change change anything about them and they are already used widely in production though. If you wish to use them together with mypy, you can simply drop <code>this plugin <https://gist.github.com/hynek/1e3844d0c99e479e716169034b5fa963#file-attrs_ng_plugin-py></code>_ into your project. Feel free to provide feedback to them in the linked issue <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a>. We will release the <code>attrs</code> namespace once we have the feeling that the APIs have properly settled. <code>[#668](python-attrs/attrs#668) <https://github.com/python-attrs/attrs/issues/668></code>_ </li> </ul> Changes ^^^^^^^ <ul> <li><code>attr.s()</code> now has a field_transformer hook that is called for all <code>Attribute</code>\ s and returns a (modified or updated) list of <code>Attribute</code> instances. <code>attr.asdict()</code> has a value_serializer hook that can change the way values are converted. Both hooks are meant to help with data (de-)serialization workflows. <code>[#653](python-attrs/attrs#653) <https://github.com/python-attrs/attrs/issues/653></code>_</li> <li><code>kw_only=True</code> now works on Python 2. <code>[#700](python-attrs/attrs#700) <https://github.com/python-attrs/attrs/issues/700></code>_</li> <li><code>raise from</code> now works on frozen classes on PyPy. <code>[#703](python-attrs/attrs#703) <https://github.com/python-attrs/attrs/issues/703></code>, <code>[#712](python-attrs/attrs#712) <https://github.com/python-attrs/attrs/issues/712></code></li> <li><code>attr.asdict()</code> and <code>attr.astuple()</code> now treat <code>frozenset</code>\ s like <code>set</code>\ s with regards to the retain_collection_types argument. <code>[#704](python-attrs/attrs#704) <https://github.com/python-attrs/attrs/issues/704></code>_</li> <li>The type stubs for <code>attr.s()</code> and <code>attr.make_class()</code> are not missing the collect_by_mro argument anymore. <code>[#711](python-attrs/attrs#711) <https://github.com/python-attrs/attrs/issues/711></code>_</li> </ul> <hr /> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/python-attrs/attrs/commit/f3762ba07bf0cec8bebdaaeca2212ba1d662ff13"><code>f3762ba</code></a> Prepare 20.3.0</li> <li><a href="https://github.com/python-attrs/attrs/commit/3d66e5727b93d3463feb0fd780ae739192e7c363"><code>3d66e57</code></a> Exclude GitHub issues from linkcheck to avoid rate limits</li> <li><a href="https://github.com/python-attrs/attrs/commit/06d0f8eda63b3f08cb5d94fff9fddf4fe6695621"><code>06d0f8e</code></a> Add funding URLs to metadata</li> <li><a href="https://github.com/python-attrs/attrs/commit/d23924f765d09f77e87a5c51c1685df0d721b469"><code>d23924f</code></a> Add provisional notice</li> <li><a href="https://github.com/python-attrs/attrs/commit/cd2f886d6372dca288abf9d999b3e35dacd9ced6"><code>cd2f886</code></a> Use 'i' and 'k' to better distinguish variables in an example (<a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/713">#713</a>)</li> <li><a href="https://github.com/python-attrs/attrs/commit/f2dabeae82c75abe174aafc7a726481ded929872"><code>f2dabea</code></a> Fix exception chaining on PyPy (<a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/712">#712</a>)</li> <li><a href="https://github.com/python-attrs/attrs/commit/6b4a1f1ce65162afe54e7101b263859bf8b2177e"><code>6b4a1f1</code></a> Tighten up mypy configuration</li> <li><a href="https://github.com/python-attrs/attrs/commit/9f7d11e415bc789c9cbab255cb9a5b8903c1b122"><code>9f7d11e</code></a> Add types to collect_by_mro annotations m(</li> <li><a href="https://github.com/python-attrs/attrs/commit/7020c8b5b55adefc76cf369fb071b1a4b15554a9"><code>7020c8b</code></a> pre-commit autoupdate</li> <li><a href="https://github.com/python-attrs/attrs/commit/56c73081c5d767e30f529ac4f15a6bdd43e23d9f"><code>56c7308</code></a> Add missing collect_by_mro to typing stubs</li> <li>Additional commits viewable in <a href="https://github.com/python-attrs/attrs/compare/20.2.0...20.3.0">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=attrs&package-manager=pip&previous-version=20.2.0&new-version=20.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end)

Bumps [attrs](https://github.com/python-attrs/attrs) from 20.2.0 to 20.3.0. <details> <summary>Release notes</summary> Sourced from <a href="https://github.com/python-attrs/attrs/releases">attrs's releases</a>. <blockquote> <h2>20.3.0</h2> <h2>Backward-incompatible Changes</h2> <ul> <li> <code>attr.define()</code>, <code>attr.frozen()</code>, <code>attr.mutable()</code>, and <code>attr.field()</code> remain provisional. This release does not change change anything about them and they are already used widely in production though. If you wish to use them together with mypy, you can simply drop <a href="https://gist.github.com/hynek/1e3844d0c99e479e716169034b5fa963#file-attrs_ng_plugin-py">this plugin</a> into your project. Feel free to provide feedback to them in the linked issue <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a>. We will release the <code>attrs</code> namespace once we have the feeling that the APIs have properly settled. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a> </li> </ul> <h2>Changes</h2> <ul> <li><code>attr.s()</code> now has a field_transformer hook that is called for all <code>Attribute</code>s and returns a (modified or updated) list of <code>Attribute</code> instances. <code>attr.asdict()</code> has a value_serializer hook that can change the way values are converted. Both hooks are meant to help with data (de-)serialization workflows. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/653">#653</a></li> <li><code>kw_only=True</code> now works on Python 2. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/700">#700</a></li> <li><code>raise from</code> now works on frozen classes on PyPy. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/703">#703</a>, <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/712">#712</a></li> <li><code>attr.asdict()</code> and <code>attr.astuple()</code> now treat <code>frozenset</code>s like <code>set</code>s with regards to the retain_collection_types argument. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/704">#704</a></li> <li>The type stubs for <code>attr.s()</code> and <code>attr.make_class()</code> are not missing the collect_by_mro argument anymore. <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/711">#711</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> Sourced from <a href="https://github.com/python-attrs/attrs/blob/master/CHANGELOG.rst">attrs's changelog</a>. <blockquote> <h2>20.3.0 (2020-11-05)</h2> Backward-incompatible Changes ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <ul> <li> <code>attr.define()</code>, <code>attr.frozen()</code>, <code>attr.mutable()</code>, and <code>attr.field()</code> remain provisional. This release does not change change anything about them and they are already used widely in production though. If you wish to use them together with mypy, you can simply drop <code>this plugin <https://gist.github.com/hynek/1e3844d0c99e479e716169034b5fa963#file-attrs_ng_plugin-py></code>_ into your project. Feel free to provide feedback to them in the linked issue <a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/668">#668</a>. We will release the <code>attrs</code> namespace once we have the feeling that the APIs have properly settled. <code>[aio-libs#668](python-attrs/attrs#668) <https://github.com/python-attrs/attrs/issues/668></code>_ </li> </ul> Changes ^^^^^^^ <ul> <li><code>attr.s()</code> now has a field_transformer hook that is called for all <code>Attribute</code>\ s and returns a (modified or updated) list of <code>Attribute</code> instances. <code>attr.asdict()</code> has a value_serializer hook that can change the way values are converted. Both hooks are meant to help with data (de-)serialization workflows. <code>[aio-libs#653](python-attrs/attrs#653) <https://github.com/python-attrs/attrs/issues/653></code>_</li> <li><code>kw_only=True</code> now works on Python 2. <code>[aio-libs#700](python-attrs/attrs#700) <https://github.com/python-attrs/attrs/issues/700></code>_</li> <li><code>raise from</code> now works on frozen classes on PyPy. <code>[aio-libs#703](python-attrs/attrs#703) <https://github.com/python-attrs/attrs/issues/703></code>, <code>[aio-libs#712](python-attrs/attrs#712) <https://github.com/python-attrs/attrs/issues/712></code></li> <li><code>attr.asdict()</code> and <code>attr.astuple()</code> now treat <code>frozenset</code>\ s like <code>set</code>\ s with regards to the retain_collection_types argument. <code>[aio-libs#704](python-attrs/attrs#704) <https://github.com/python-attrs/attrs/issues/704></code>_</li> <li>The type stubs for <code>attr.s()</code> and <code>attr.make_class()</code> are not missing the collect_by_mro argument anymore. <code>[aio-libs#711](python-attrs/attrs#711) <https://github.com/python-attrs/attrs/issues/711></code>_</li> </ul> <hr /> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/python-attrs/attrs/commit/f3762ba07bf0cec8bebdaaeca2212ba1d662ff13"><code>f3762ba</code></a> Prepare 20.3.0</li> <li><a href="https://github.com/python-attrs/attrs/commit/3d66e5727b93d3463feb0fd780ae739192e7c363"><code>3d66e57</code></a> Exclude GitHub issues from linkcheck to avoid rate limits</li> <li><a href="https://github.com/python-attrs/attrs/commit/06d0f8eda63b3f08cb5d94fff9fddf4fe6695621"><code>06d0f8e</code></a> Add funding URLs to metadata</li> <li><a href="https://github.com/python-attrs/attrs/commit/d23924f765d09f77e87a5c51c1685df0d721b469"><code>d23924f</code></a> Add provisional notice</li> <li><a href="https://github.com/python-attrs/attrs/commit/cd2f886d6372dca288abf9d999b3e35dacd9ced6"><code>cd2f886</code></a> Use 'i' and 'k' to better distinguish variables in an example (<a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/713">#713</a>)</li> <li><a href="https://github.com/python-attrs/attrs/commit/f2dabeae82c75abe174aafc7a726481ded929872"><code>f2dabea</code></a> Fix exception chaining on PyPy (<a href="https://github-redirect.dependabot.com/python-attrs/attrs/issues/712">#712</a>)</li> <li><a href="https://github.com/python-attrs/attrs/commit/6b4a1f1ce65162afe54e7101b263859bf8b2177e"><code>6b4a1f1</code></a> Tighten up mypy configuration</li> <li><a href="https://github.com/python-attrs/attrs/commit/9f7d11e415bc789c9cbab255cb9a5b8903c1b122"><code>9f7d11e</code></a> Add types to collect_by_mro annotations m(</li> <li><a href="https://github.com/python-attrs/attrs/commit/7020c8b5b55adefc76cf369fb071b1a4b15554a9"><code>7020c8b</code></a> pre-commit autoupdate</li> <li><a href="https://github.com/python-attrs/attrs/commit/56c73081c5d767e30f529ac4f15a6bdd43e23d9f"><code>56c7308</code></a> Add missing collect_by_mro to typing stubs</li> <li>Additional commits viewable in <a href="https://github.com/python-attrs/attrs/compare/20.2.0...20.3.0">compare view</a></li> </ul> </details> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=attrs&package-manager=pip&previous-version=20.2.0&new-version=20.3.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/configuring-github-dependabot-security-updates) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end)

hynek added 2 commits November 4, 2020 10:04

Fix exception chaining on PyPy

2d2e0d2

Fixes #703

Add newsfragment

e419166

hynek added this to the 20.3.0 milestone Nov 4, 2020

hynek mentioned this pull request Nov 4, 2020

Frozen Exceptions cannot be thrown from Exception Handler in PyPy #703

Closed

hynek added 2 commits November 4, 2020 10:14

Blankly exclude PyPy from coverage reporting

4df8a98

Manually add default no cover marker

d9370b0

hynek merged commit f2dabea into master Nov 4, 2020

hynek deleted the pypy-exc-chain branch November 4, 2020 10:02

This was referenced Mar 15, 2021

Bump attrs from 19.3.0 to 20.3.0 release-engineering/exodus-lambda#127

Merged

Bump attrs from 20.1.0 to 20.3.0 CSCfi/oidc-client#27

Merged

Julian mentioned this pull request Jan 6, 2023

Fix @frozen exceptions to allow __traceback__ to be set. #1081

Merged

12 tasks

A5rocks mentioned this pull request Mar 14, 2023

collapse_exception_group breaks with exceptions that are also frozen dataclasses python-trio/trio#2607

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix exception chaining on PyPy #712

Fix exception chaining on PyPy #712

hynek commented Nov 4, 2020

N-Coder commented Nov 4, 2020

hynek commented Nov 4, 2020

Fix exception chaining on PyPy #712

Fix exception chaining on PyPy #712

Conversation

hynek commented Nov 4, 2020

N-Coder commented Nov 4, 2020

hynek commented Nov 4, 2020