Add support for parent locale exceptions #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the <parentLocales> element contains the locale inheritance exceptions
when deriving the parent locale from the given name, look in the parent exceptions first (e.g. the parent of "es_MX" is "es_419", not "es")
According to the colombian locales, the currency symbol is placed at the beginning, like in english locales. This needs to be changed because "es_CO" now inherits the definitions from "es_419", thus conforming to the standard.
This was referenced Dec 5, 2014
|
This fixes issue #97 too |
|
@etanol reopen if you have a special reason for keeping this one alive. |
|
Superseded by #180 since GitHub's UI does not allow to change the base/origin branch. |
|
2.1.1 onwards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method to generate the name for the parent locale has some exceptions. Notably the latin america regions (
es_MX,es_CO,es_AR, etc...) which should inherit fromes_419instead ofes. Fortunately, these exceptions are described in the element of the supplemental data document.This pull request tries to implement the proper locale inheritance for such cases.
There is an ugly hack because one of the commits introduces a circular dependency between
babel.coreandbabel.locale.