Use currency fraction information #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the <parentLocales> element contains the locale inheritance exceptions
when deriving the parent locale from the given name, look in the parent exceptions first (e.g. the parent of "es_MX" is "es_419", not "es")
According to the colombian locales, the currency symbol is placed at the beginning, like in english locales. This needs to be changed because "es_CO" now inherits the definitions from "es_419", thus conforming to the standard.
Also save the <fractions> section of the supplemental data, which indicates how many decimal places should be displayed for each currency.
As NumberFormat instances seem to be cached, we want to override this attribute just temporarily.
While keeping API backwards compatibility, add a new parameter to numbers.format_currency that will use the digit information associated to the currency code to override whatever is indicated in the pattern regarding decimal digits.
|
The tests are already broken on |
When traversing or printing dictionaries and sets, the ordering is not
guaranteed across runs (due to Python using a different random seed for hashing
strings on every execution). Reference:
https://docs.python.org/3/library/doctest.html#warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends pull request #117 to also load the currency fraction information from CLDR supplemental data. Once loaded, it adds an option to
babel.numbers.format_currencyso the decimal positions deduced from the format pattern can be ignored and replaced by those of the currency, as indicated by such supplemental information.The API remains backwards compatible.