Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
akx
added
the
enhancement
label
Dec 30, 2015
sils
added
the
(2) in progress
label
Dec 30, 2015
gitmate-bot
added
the
size/XL
label
Dec 30, 2015
akx
force-pushed the
akx:refactor-frontend
branch
2 times, most recently
from
6fc7d0c
to
0229d4c
Dec 30, 2015
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
Dec 30, 2015
Current coverage is
|
akx
added
(3) pending review
and removed
(2) in progress
labels
Dec 30, 2015
akx
added this to the
Babel 2.3/3.0 milestone
Jan 3, 2016
akx
added some commits
Dec 30, 2015
akx
force-pushed the
akx:refactor-frontend
branch
from
f63687e
to
fd22a8e
Jan 4, 2016
This comment has been minimized.
This comment has been minimized.
|
@sils1297 Feel free to merge this..? |
This comment has been minimized.
This comment has been minimized.
|
@akx I don't have time to do a full review :/ it seems well tested and a good improvement, if you're confident, feel free to merge |
This comment has been minimized.
This comment has been minimized.
|
I'm pretty confident. Let's see how it goes :) |
added a commit
that referenced
this pull request
Jan 8, 2016
akx
merged commit 1b4cd01
into
python-babel:master
Jan 8, 2016
5 of 6 checks passed
review/gitmate/manual
This commit needs review.
Details
Scrutinizer
9 updated code elements
Details
codecov/project
88.28% (+4.02%) compared to 3aa3f29 at 84.26%
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
review/gitmate/commit
All is well! :)
Details
sils
removed
the
(3) pending review
label
Jan 8, 2016
akx
deleted the
akx:refactor-frontend
branch
Jan 8, 2016
This was referenced Jan 11, 2016
added a commit
to akx/babel
that referenced
this pull request
Apr 14, 2016
akx
referenced this pull request
Apr 14, 2016
Merged
Re-harmonize argument parsing between distutils and optparse CLIs #389
paxswill
referenced this pull request
Apr 14, 2016
Closed
pybabel extract forgot the -s CLI flag in version 2.3 #390
added a commit
to akx/babel
that referenced
this pull request
Apr 17, 2016
added a commit
to akx/babel
that referenced
this pull request
Apr 17, 2016
added a commit
to akx/babel
that referenced
this pull request
Apr 19, 2016
added a commit
to karloskar/babel
that referenced
this pull request
Oct 21, 2016
added a commit
to karloskar/babel
that referenced
this pull request
Oct 21, 2016
added a commit
to karloskar/babel
that referenced
this pull request
Oct 21, 2016
This was referenced Feb 19, 2017
This was referenced Aug 17, 2017
This was referenced Aug 26, 2017
This was referenced Sep 4, 2017
This was referenced Oct 12, 2017
This was referenced Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
akx commentedDec 30, 2015
This PR is directly inspired by #62.
A little bit of intricate, fine magic is used to create an Optparse parser out of the Distutils commands, a little bit of fine-tuning here and there and then everything . . . just works, with a third less code.
The
,fuzzychanges in the tests are actually an oversight that this PR fixes as a side effect: The commit e85e71d had addedcatalog.fuzzy = Falseto the distutils command code, but the same change had never made it into the CLI code.This should do wonders for test coverage statistics, which also means the frontend code will be more easily maintained.