Refactor frontend.py (remove duplicate code) #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
refactor-frontend
branch
2 times, most recently
from
6fc7d0c to
0229d4c
Compare
Current coverage is
|
|
@sils1297 Feel free to merge this..? |
|
@akx I don't have time to do a full review :/ it seems well tested and a good improvement, if you're confident, feel free to merge |
|
I'm pretty confident. Let's see how it goes :) |
akx
added a commit
that referenced
this pull request
Jan 8, 2016
Refactor frontend.py (remove duplicate code)
This was referenced Jan 11, 2016
akx
added a commit
to akx/babel
that referenced
this pull request
Apr 14, 2016
akx
added a commit
to akx/babel
that referenced
this pull request
Apr 17, 2016
akx
added a commit
to akx/babel
that referenced
this pull request
Apr 17, 2016
akx
added a commit
to akx/babel
that referenced
this pull request
Apr 19, 2016
akx
added a commit
to akx/babel
that referenced
this pull request
Apr 19, 2016
akx
added a commit
to akx/babel
that referenced
this pull request
Apr 22, 2016
This is a combination of the test suite improvement fbc1648 and the frontend changes in 414aec5..ee8abd6. * Harmonize extraction keyword parsing between distutils and standalone CLI (python-babel#388, python-babel#384, python-babel#311) * Don't use unicode-variant %r for logging * extract: don't die badly when no input paths are specified in optparse mode * Remind the optparse CLI about `extract -s` (a shorthand for `--strip-comments`) (python-babel#390) * Teach the optparse CLI about the parameter aliases it had forgotten in python-babel#311 (python-babel#390)
akx
added a commit
to akx/babel
that referenced
this pull request
Apr 22, 2016
This is a combination of the test suite improvement fbc1648 and the frontend changes in 414aec5..ee8abd6. * Harmonize extraction keyword parsing between distutils and standalone CLI (python-babel#388, python-babel#384, python-babel#311) * Don't use unicode-variant %r for logging * extract: don't die badly when no input paths are specified in optparse mode * Remind the optparse CLI about `extract -s` (a shorthand for `--strip-comments`) (python-babel#390) * Teach the optparse CLI about the parameter aliases it had forgotten in python-babel#311 (python-babel#390)
akx
added a commit
to akx/babel
that referenced
this pull request
Apr 22, 2016
This is a combination of the test suite improvement fbc1648 and the frontend changes in 414aec5..ee8abd6. * Harmonize extraction keyword parsing between distutils and standalone CLI (python-babel#388, python-babel#384, python-babel#311) * Don't use unicode-variant %r for logging * extract: don't die badly when no input paths are specified in optparse mode * Remind the optparse CLI about `extract -s` (a shorthand for `--strip-comments`) (python-babel#390) * Teach the optparse CLI about the parameter aliases it had forgotten in python-babel#311 (python-babel#390)
This was referenced Feb 19, 2017
Closed
This was referenced Aug 17, 2017
This was referenced Aug 26, 2017
This was referenced Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is directly inspired by #62.
A little bit of intricate, fine magic is used to create an Optparse parser out of the Distutils commands, a little bit of fine-tuning here and there and then everything . . . just works, with a third less code.
The
,fuzzychanges in the tests are actually an oversight that this PR fixes as a side effect: The commit e85e71d had addedcatalog.fuzzy = Falseto the distutils command code, but the same change had never made it into the CLI code.This should do wonders for test coverage statistics, which also means the frontend code will be more easily maintained.