New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make catalog header updating an option #320

Merged
merged 1 commit into from Jan 8, 2016

Conversation

Projects
None yet
5 participants
@akx
Member

akx commented Jan 8, 2016

The change in e0e7ef1 had an unexpected and likely undesired effect
when updating catalogs with, e.g. translator names in the header comment.

It's better to make the updating an option and revert back to the pre-2.2
behavior by default.

Fixes #318

@akx akx added the bug label Jan 8, 2016

@sils sils added the (2) in progress label Jan 8, 2016

@gitmate-bot gitmate-bot added the size/S label Jan 8, 2016

@akx akx force-pushed the akx:update-option branch from a589d36 to cb72f31 Jan 8, 2016

@codecov-io

This comment has been minimized.

codecov-io commented Jan 8, 2016

Current coverage is 88.29%

Merging #320 into master will increase coverage by +0.01% as of cd96127

@@            master    #320   diff @@
======================================
  Files           22      22       
  Stmts         3595    3597     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           3174    3176     +2
  Partial          0       0       
  Missed         421     421       

Review entire Coverage Diff as of cd96127

Powered by Codecov. Updated on successful CI builds.

@sils

This comment has been minimized.

Member

sils commented Jan 8, 2016

@akx needs more test coverage.

@akx

This comment has been minimized.

Member

akx commented Jan 8, 2016

@sils1297 The lack of test coverage would be fixed by merging #311. Right now the distutils versions of command code are not tested at all, but the other copies are.

I published the option only in the distutils code anticipating that merge.

@ajaeger

This comment has been minimized.

ajaeger commented Jan 8, 2016

Tested this locally and it works as expected - fixes issue #318 in my setup. Thanks!

@akx

This comment has been minimized.

Member

akx commented Jan 8, 2016

I can also just remove the new option in the distutils code, but that seems like doing it just to make Codecov happy, and we're not writing code for CI robots. :)

@sils

This comment has been minimized.

Member

sils commented Jan 8, 2016

@akx then lets merge #311 first?

@akx akx force-pushed the akx:update-option branch 2 times, most recently from 59831b5 to 672f96c Jan 8, 2016

@akx

This comment has been minimized.

Member

akx commented Jan 8, 2016

Hey @ajaeger, if you have the time, could you check that this branch still works for your UC (after it was rebased)? Thank you!

Make catalog header updating an option
The change in e0e7ef1 had an unexpected and likely undesired effect
when updating catalogs with, e.g. translator names in the header comment.

It's better to make the updating an option and revert back to the pre-2.2
behavior by default.

Fixes #318

@akx akx force-pushed the akx:update-option branch from 672f96c to 28fe677 Jan 8, 2016

akx added a commit that referenced this pull request Jan 8, 2016

Merge pull request #320 from akx/update-option
Make catalog header updating an option

@akx akx merged commit 2e20745 into python-babel:master Jan 8, 2016

5 of 6 checks passed

review/gitmate/manual This commit needs review.
Details
Scrutinizer No new issues
Details
codecov/project 88.29% (+0.01%) compared to 47ac442 at 88.28%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
review/gitmate/commit All is well! :)
Details

@sils sils removed the (2) in progress label Jan 8, 2016

@akx akx deleted the akx:update-option branch Jan 8, 2016

@ajaeger

This comment has been minimized.

ajaeger commented Jan 8, 2016

@akx tested current head that includes the patch and it works fine. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment