Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a failing test for issue #27 #28

Closed
wants to merge 2 commits into from

Conversation

benwad
Copy link

@benwad benwad commented Feb 10, 2016

No description provided.

@graingert
Copy link
Contributor

@sils1297 any idea why this PR isn't building on Travis?

@sils
Copy link
Member

sils commented Feb 11, 2016

@graingert maybe the hook got lost due to a downtime on travis side? There was a github outage on 8th but this shouldn't be affected. @benwad you can git commit --amend, save and git push --force to resync your branch which will push a new commit with the same contents to github and retrigger CI.

Alternatively you can push an empty commit on top if your policy is against force pushes: git commit --allow-empty.

@graingert
Copy link
Contributor

@sils1297 I ❤️ force pushes

@sils
Copy link
Member

sils commented Feb 11, 2016

@graingert me too :) Though it's hard to get people to write proper commits using that if they never used git before and a word of caution is in order especially since some of those people even use master for development...

@graingert
Copy link
Contributor

@benwad won't this need to have Jinja2 installed to work?

@graingert
Copy link
Contributor

issue #27

@benwad
Copy link
Author

benwad commented Apr 4, 2016

@graingert sorry for the delay, yes this will need Jinja2. Where do I need to add that requirement for the test?

@graingert
Copy link
Contributor

@benwad
Copy link
Author

benwad commented Apr 4, 2016

@graingert thanks, I've pushed the change.

@graingert
Copy link
Contributor

@benwad you also need to rebase this PR

@graingert
Copy link
Contributor

@benwad I'm also pretty sure you need to configure django to enable Jinja2, and configure your Jinja2 environment, and disable the tests on Django versions without pluggable template engines.

@graingert
Copy link
Contributor

As discussed in the issue, you should use the babel Jinja2 library to get this to work.

@graingert graingert closed this Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants