-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a failing test for issue #27 #28
Conversation
@sils1297 any idea why this PR isn't building on Travis? |
@graingert maybe the hook got lost due to a downtime on travis side? There was a github outage on 8th but this shouldn't be affected. @benwad you can Alternatively you can push an empty commit on top if your policy is against force pushes: |
@sils1297 I ❤️ force pushes |
@graingert me too :) Though it's hard to get people to write proper commits using that if they never used git before and a word of caution is in order especially since some of those people even use master for development... |
@benwad won't this need to have Jinja2 installed to work? |
issue #27 |
@graingert sorry for the delay, yes this will need Jinja2. Where do I need to add that requirement for the test? |
@graingert thanks, I've pushed the change. |
@benwad you also need to rebase this PR |
@benwad I'm also pretty sure you need to configure django to enable Jinja2, and configure your Jinja2 environment, and disable the tests on Django versions without pluggable template engines. |
As discussed in the issue, you should use the babel Jinja2 library to get this to work. |
No description provided.