Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #289 - basic auth broken towards some servers #290

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Conversation

tobixen
Copy link
Member

@tobixen tobixen commented Feb 25, 2023

No description provided.

@tobixen tobixen added this pull request to the merge queue Feb 25, 2023
Merged via the queue into master with commit 4d1beb9 Feb 25, 2023
@tobixen
Copy link
Member Author

tobixen commented Feb 26, 2023

Background:

A bug was introduced in version 1.0, via #260 - the code would only work if there was a space in the WWW-Authenticate header. This works for most servers as they will challenge for credentials using a header like WWW-Authenticate: Basic realm="My CalDAV server" - however, WWW-Authenticate: Basic is fully allowed by RFC2617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant