Fix legacy Font Awesome icon classes #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedyhli
added
area: frontend
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I noticed there are a few more FA icons on our site that needs fixing, from looking at a deploy preview from before #1232 the issue might be from upgrading FA, from which incompatible classes we might've missed. I think I'll just fix those as well in this PR together since I found them already. |
hedyhli
added
status: WIP
hedyhli
changed the title
hedyhli
added
s: needs review
jchristgit
approved these changes
Mar 14, 2024
|
There's a one-liner fix for that which just changes hidden items from |
Xithrius
added
priority: 2 - normal
Xithrius
requested review from
ChrisLovering and
jchristgit
and removed request for
jchristgit
|
I'm bad at requesting reviews, apologies |
ChrisLovering
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using some Font Awesome 4 classes, eg:
Which have since been removed. They don't show up correctly after switching to Font Awesome 6 (in #1232).
This is because the Kit we were previously using included some JS files that handled the backwards compatibility. (Thanks to @lemonsaurus for finding this out)
This fix replaces these font awesome classes to the most sensible replacements I could find, which are the new class names and should all display correctly.
Timeline
https://pythondiscord.com/timeline/
https://deploy-preview-1255--pydis-static.netlify.app/timeline/
1
2
Resources
https://pythondiscord.com/resources/?type=project-ideas
https://deploy-preview-1255--pydis-static.netlify.app/resources/?type=project-ideas
Code Jam results
https://www.pythondiscord.com/events/code-jams/
https://deploy-preview-1255--pydis-static.netlify.app/events/code-jams/
For CJ10, 9, 8.