Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set elidable on RunPython operations in migrations #1280

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

jchristgit
Copy link
Member

Any RunPython operation that only migrated existing data (that is, did not create data) can be safely elided by Django when we run squashmigrations.

Any RunPython operation that only migrated existing data (that is, did
not create data) can be safely elided by Django when we run
`squashmigrations`.
@jchristgit jchristgit added area: backend Related to internal functionality and utilities language: python Involves Python code priority: 3 - low Low Priority level: 2 - advanced type: enhancement Changes or improvements to existing features labels Mar 31, 2024
Copy link

netlify bot commented Mar 31, 2024

Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit a70ad81
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/660c5225c206d900087936be
😎 Deploy Preview https://deploy-preview-1280--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Mar 31, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling a70ad81 on set-elidable-on-run-python-operations-in-migrations
into 6b128e1 on main.

Copy link
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wookie184 wookie184 enabled auto-merge April 2, 2024 18:44
@wookie184 wookie184 merged commit 38599b6 into main Apr 2, 2024
11 checks passed
@wookie184 wookie184 deleted the set-elidable-on-run-python-operations-in-migrations branch April 2, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to internal functionality and utilities language: python Involves Python code level: 2 - advanced priority: 3 - low Low Priority type: enhancement Changes or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants