Don't propagate the status received from Discord to GitHub Webhook #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
MarkKoz
approved these changes
Apr 1, 2024
pydis_site/apps/api/views.py
Outdated
Comment on lines
306
to
307
| headers.pop('Connection', None) | ||
| headers.pop('Content-Length', None) |
There was a problem hiding this comment.
We don't need to do this anymore, right?
There was a problem hiding this comment.
Good spot, removed in 346d570
pydis_site/apps/api/views.py
Outdated
|
|
||
| response_body = { | ||
| "original_status": response_status, | ||
| "data": body.decode("utf-8"), |
There was a problem hiding this comment.
How does GH know it has to look in this nested structure now instead of the root?
There was a problem hiding this comment.
It doesn't -- but it doesn't need to, GitHub stores all response details for us to browse, it doesn't do any processing of this response. I'm going to add a sanity log on our side though to mark when we get a 400 from downstream (but without logging sensitive info).
jb3
force-pushed
the
jb3/github-webhook-no-status
branch
2 times, most recently
from
229d8fb
to
891df20
Compare
jb3
added
area: backend
jb3
force-pushed
the
jb3/github-webhook-no-status
branch
from
891df20
to
3d04acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we received a bad request exception from Discord (which is not actually representative of an error here), we were propagating this back to GitHub.
Instead, we should always return a success request if we have been successful in the proxy attempt, and return the downstream status code as a part of the response body.
This prevents GitHub Webhook Bad Requests being logged to site logs.