Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Adafruit from front-page sponsors listing #429

Merged
merged 2 commits into from
Nov 28, 2020
Merged

Remove Adafruit from front-page sponsors listing #429

merged 2 commits into from
Nov 28, 2020

Conversation

ks129
Copy link
Member

@ks129 ks129 commented Nov 28, 2020

Closes #428

Remove Adafruit from front-page sponsors listing.

@ks129 ks129 requested a review from Den4200 as a code owner November 28, 2020 13:51
@ghost ghost added the needs 2 approvals label Nov 28, 2020
@coveralls
Copy link

coveralls commented Nov 28, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling d59186a on ks129/frontpage-adafruit-remove into 0303adc on master.

lemonsaurus
lemonsaurus approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@lemonsaurus lemonsaurus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ks129

images/sponsors/adafruit.png is used elsewhere, then? or will be in the dewikification branch when code jam pages are moved, is that your thinking? Just in terms of why the asset wasn't removed.

@ks129
Copy link
Member Author

ks129 commented Nov 28, 2020

Actually, this is not used anywhere, because code jam pages doesn't contain it.

@ghost ghost removed the needs 1 approval label Nov 28, 2020
@Den4200 Den4200 merged commit 0ce9cc5 into master Nov 28, 2020
@Den4200 Den4200 deleted the ks129/frontpage-adafruit-remove branch November 28, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemonsaurus lemonsaurus lemonsaurus approved these changes

@Den4200 Den4200 Den4200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the Adafruit logo from the sponsors block
4 participants
@ks129 @coveralls @lemonsaurus @Den4200