Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max-requests-jitter parameter to gunicorn #431

Merged
merged 3 commits into from
Dec 6, 2020
Merged

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Dec 5, 2020

Set the max requests parameter for gunicorn to restart our workers between 1 and 1000 requests to help control the damage of memory leaks. This comes after we observed over 1GB RAM usage from our site container.

A bonus feature of this PR is that it integrates the statsd client inside gunicorn to report to our graphite server so we should be able to measure metric data.

@jb3 jb3 requested a review from Den4200 as a code owner December 5, 2020 15:41
@ghost ghost added the needs 2 approvals label Dec 5, 2020
@jb3 jb3 added area: backend Related to internal functionality and utilities area: CI Related to continuous intergration and deployment priority: 0 - critical Needs to be addressed ASAP labels Dec 5, 2020
@coveralls
Copy link

coveralls commented Dec 5, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 4e0ec7b on gunicorn/max-requests into 522d017 on master.

manage.py Outdated Show resolved Hide resolved
@ghost ghost added s: waiting for author Waiting for author to address a review or respond to a comment and removed needs 1 approval labels Dec 6, 2020
Co-authored-by: Sebastiaan Zeeff <33516116+SebastiaanZ@users.noreply.github.com>
@ghost ghost added needs 1 approval and removed s: waiting for author Waiting for author to address a review or respond to a comment labels Dec 6, 2020
@ghost ghost removed the needs 1 approval label Dec 6, 2020
@jb3 jb3 merged commit 6405db4 into master Dec 6, 2020
@jb3 jb3 deleted the gunicorn/max-requests branch December 6, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to internal functionality and utilities area: CI Related to continuous intergration and deployment priority: 0 - critical Needs to be addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants