Apply LimitOffsetPagination in GET Infraction with default Page Size 100 #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akarys42
suggested changes
Jan 27, 2021
kunal097
commented
Jan 28, 2021
MarkKoz
requested changes
Jan 29, 2021
MarkKoz
requested changes
Feb 25, 2021
MarkKoz
approved these changes
Mar 4, 2021
pydis_site/apps/api/pagination.py
Outdated
Comment on lines
14
to
41
| { | ||
| "count": 1, | ||
| "next": null, | ||
| "previous": null, | ||
| "results": [{ | ||
| "id": 6, | ||
| "inserted_at": "2021-01-26T21:13:35.477879Z", | ||
| "expires_at": null, | ||
| "active": false, | ||
| "user": 1, | ||
| "actor": 2, | ||
| "type": "warning", | ||
| "reason": null, | ||
| "hidden": false | ||
| }] | ||
| } | ||
| ## Required response | ||
| [{ | ||
| "id": 6, | ||
| "inserted_at": "2021-01-26T21:13:35.477879Z", | ||
| "expires_at": null, | ||
| "active": false, | ||
| "user": 1, | ||
| "actor": 2, | ||
| "type": "warning", | ||
| "reason": null, | ||
| "hidden": false | ||
| }] |
There was a problem hiding this comment.
For consistency, ideally these would be formatted like the docs for viewsets. They are formatted as if they were copied from a Python REPL. They are also not indented consistently.
Co-authored-by: Mark <kozlovmark@gmail.com>
Co-authored-by: Mark <kozlovmark@gmail.com>
Co-authored-by: Mark <kozlovmark@gmail.com>
Co-authored-by: Mark <kozlovmark@gmail.com>
Co-authored-by: Mark <kozlovmark@gmail.com>
Akarys42
approved these changes
Apr 24, 2021
Akarys42
approved these changes
Apr 24, 2021
Qwerty-133
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Default Pagination class LimitOffsetPagination with Page Size 100 in GET Infraction