Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New error pages #450

Merged
merged 5 commits into from
Mar 1, 2021
Merged

New error pages #450

merged 5 commits into from
Mar 1, 2021

Conversation

gustavwilliam
Copy link
Member

This PR adds pages for 404 and 500 errors on the site. They are following the same structure as the recently merged custom CF error pages (python-discord/error-pages#1).

Preview

404

Screenshot 2021-03-01 at 17 16 07

500

Screenshot 2021-03-01 at 17 17 33

@gustavwilliam
Add 404 page
ebf128e 
This does not include the styling required for the page to display
properly
@gustavwilliam
Add error page styling
3020e2e 
This css sheet applies to the 404 and 500 pages
@gustavwilliam
Add 500 page
df9f590
@gustavwilliam gustavwilliam added area: frontend Related to site content and user interaction type: feature New feature or request priority: 2 - normal Normal Priority labels Mar 1, 2021
@coveralls
Copy link

coveralls commented Mar 1, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9243fef on error_pages into 97d0ece on master.

@gustavwilliam gustavwilliam requested a review from ks129 March 1, 2021 16:45
lemonsaurus
lemonsaurus approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good overall. Excellent work, @gustavwilliam.

pydis_site/templates/404.html Outdated Show resolved Hide resolved
pydis_site/templates/500.html Outdated Show resolved Hide resolved
jb3
jb3 requested changes Mar 1, 2021
View reviewed changes
Copy link
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comment on wording + including a Discord link on the 500 page as well as the 404 one.

pydis_site/templates/500.html Outdated Show resolved Hide resolved
gustavwilliam and others added 2 commits March 1, 2021 20:28
@gustavwilliam @lemonsaurus
Capitalise error codes in 404 and 500 pages
1ed129f 
Co-authored-by: Leon Sandøy <leon.haland@gmail.com>
@gustavwilliam
Update error message for 500 page
9243fef 
Now includes a link to our Discord server and concrete actions for the user, if the problem persists
@gustavwilliam gustavwilliam requested a review from jb3 March 1, 2021 19:36
jb3
jb3 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit::shipit::shipit::shipit::shipit:

@jb3 jb3 merged commit 9375d27 into master Mar 1, 2021
@jb3 jb3 deleted the error_pages branch March 1, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemonsaurus lemonsaurus lemonsaurus approved these changes

@jb3 jb3 jb3 approved these changes

@HassanAbouelela HassanAbouelela Awaiting requested review from HassanAbouelela

@ks129 ks129 Awaiting requested review from ks129

Assignees
No one assigned
Labels
area: frontend Related to site content and user interaction priority: 2 - normal Normal Priority type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gustavwilliam @coveralls @lemonsaurus @jb3