Add route to get a member's data for helper review #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added route for getting a user's join date, total messages, and top 3 channels by activity. This information will be used to auto-review nominees.
mbaruh
changed the title
jb3
approved these changes
Mar 11, 2021
Comment on lines
+106
to
+107
| WHEN channels.name ILIKE 'help-%%' THEN 'the help channels' | ||
| WHEN channels.name ILIKE 'ot%%' THEN 'off-topic' |
There was a problem hiding this comment.
Grammar here is irking me a bit.
Suggested change
| WHEN channels.name ILIKE 'help-%%' THEN 'the help channels' | |
| WHEN channels.name ILIKE 'ot%%' THEN 'off-topic' | |
| WHEN channels.name ILIKE 'help-%%' THEN 'Help channels' | |
| WHEN channels.name ILIKE 'ot%%' THEN 'Off topic' |
There was a problem hiding this comment.
The purpose of those names is to be used in a sentence, rather than titles, although I agree it's not the prettiest
There was a problem hiding this comment.
Ah, gotcha, I thought it would be more a sort of list like ```
Help channels: 24,404 messages
Off topic: 12,000 messages
...: ... messages
Co-authored-by: Joe Banks <joseph@josephbanks.me>
MarkKoz
requested changes
Mar 12, 2021
| joined_at = "foo" | ||
| total_messages = 10 | ||
| total_blocks = 1 | ||
| channel_activity = [["bar", 4], ["buzz", 6]] |
There was a problem hiding this comment.
There should be subtests to test each case in the query (i.e. you need to test off topic and help channels too).
MarkKoz
added
area: API
MarkKoz
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added route for getting a user's join date, total messages, and top 3 channels by activity.
This information will be used to auto-review nominees.
Thank you @jb3 for the query, and everyone who helped me set-up metricity.