-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route to get a member's data for helper review #451
Conversation
Added route for getting a user's join date, total messages, and top 3 channels by activity. This information will be used to auto-review nominees.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good! Couple of minor comments.
WHEN channels.name ILIKE 'help-%%' THEN 'the help channels' | ||
WHEN channels.name ILIKE 'ot%%' THEN 'off-topic' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Grammar here is irking me a bit.
WHEN channels.name ILIKE 'help-%%' THEN 'the help channels' | |
WHEN channels.name ILIKE 'ot%%' THEN 'off-topic' | |
WHEN channels.name ILIKE 'help-%%' THEN 'Help channels' | |
WHEN channels.name ILIKE 'ot%%' THEN 'Off topic' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of those names is to be used in a sentence, rather than titles, although I agree it's not the prettiest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, gotcha, I thought it would be more a sort of list like ```
Help channels: 24,404 messages
Off topic: 12,000 messages
...: ... messages
Co-authored-by: Joe Banks <joseph@josephbanks.me>
joined_at = "foo" | ||
total_messages = 10 | ||
total_blocks = 1 | ||
channel_activity = [["bar", 4], ["buzz", 6]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be subtests to test each case in the query (i.e. you need to test off topic and help channels too).
Added route for getting a user's join date, total messages, and top 3 channels by activity.
This information will be used to auto-review nominees.
Thank you @jb3 for the query, and everyone who helped me set-up metricity.